Refactor: Simplify parameter validation

cubewise-code · Nov 12, 2024 · 896dd41 · 896dd41
1 parent 20bfffd
commit 896dd41
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/TM1py/Services/CubeService.py b/TM1py/Services/CubeService.py
@@ -145,9 +145,7 @@ def update_or_create_rules(self, cube_name: str, rules: Union[str, Rules], **kwa
         """
         if isinstance(rules, str):
             rules = Rules(rules=rules)
-        if isinstance(rules, Rules):
-            pass
-        else:
+        if not isinstance(rules, Rules):
             raise ValueError('rules must be type str or Rules')
 
         url = format_url("/Cubes('{}')", cube_name)