Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update dependencies #620

wants to merge 2 commits into from

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented May 2, 2024

🤔 What's changed?

Libraries are updated to their latest versions.

⚡️ What's your motivation?

With newer versions, we can benefit from the improvements that were introduced.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

No.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

github-actions bot commented May 2, 2024

Go API Changes

# github.com/cucumber/godog
## incompatible changes
AfterScenarioHook: changed from func(context.Context, *github.com/cucumber/messages/go/v21.Pickle, error) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v24.Pickle, error) (context.Context, error)
AfterStepHook: changed from func(context.Context, *github.com/cucumber/messages/go/v21.PickleStep, github.com/cucumber/godog/internal/models.StepResultStatus, error) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v24.PickleStep, github.com/cucumber/godog/internal/models.StepResultStatus, error) (context.Context, error)
BeforeScenarioHook: changed from func(context.Context, *github.com/cucumber/messages/go/v21.Pickle) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v24.Pickle) (context.Context, error)
BeforeStepHook: changed from func(context.Context, *github.com/cucumber/messages/go/v21.PickleStep) (context.Context, error) to func(context.Context, *github.com/cucumber/messages/go/v24.PickleStep) (context.Context, error)
DocString: changed from github.com/cucumber/messages/go/v21.PickleDocString to github.com/cucumber/messages/go/v24.PickleDocString
GherkinDocument: changed from github.com/cucumber/messages/go/v21.GherkinDocument to github.com/cucumber/messages/go/v24.GherkinDocument
Scenario: changed from github.com/cucumber/messages/go/v21.Pickle to github.com/cucumber/messages/go/v24.Pickle
ScenarioContext.AfterScenario: changed from func(func(sc *github.com/cucumber/messages/go/v21.Pickle, err error)) to func(func(sc *github.com/cucumber/messages/go/v24.Pickle, err error))
ScenarioContext.AfterStep: changed from func(func(st *github.com/cucumber/messages/go/v21.PickleStep, err error)) to func(func(st *github.com/cucumber/messages/go/v24.PickleStep, err error))
ScenarioContext.BeforeScenario: changed from func(func(sc *github.com/cucumber/messages/go/v21.Pickle)) to func(func(sc *github.com/cucumber/messages/go/v24.Pickle))
ScenarioContext.BeforeStep: changed from func(func(st *github.com/cucumber/messages/go/v21.PickleStep)) to func(func(st *github.com/cucumber/messages/go/v24.PickleStep))
Step: changed from github.com/cucumber/messages/go/v21.PickleStep to github.com/cucumber/messages/go/v24.PickleStep
Table: changed from github.com/cucumber/messages/go/v21.PickleTable to github.com/cucumber/messages/go/v24.PickleTable

# github.com/cucumber/godog/formatters
## incompatible changes
Formatter.Defined: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition)
Formatter.Failed: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition, error) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition, error)
Formatter.Feature: changed from func(*github.com/cucumber/messages/go/v21.GherkinDocument, string, []byte) to func(*github.com/cucumber/messages/go/v24.GherkinDocument, string, []byte)
Formatter.Passed: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition)
Formatter.Pending: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition)
Formatter.Pickle: changed from func(*github.com/cucumber/messages/go/v21.Pickle) to func(*github.com/cucumber/messages/go/v24.Pickle)
Formatter.Skipped: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition)
Formatter.Undefined: changed from func(*github.com/cucumber/messages/go/v21.Pickle, *github.com/cucumber/messages/go/v21.PickleStep, *StepDefinition) to func(*github.com/cucumber/messages/go/v24.Pickle, *github.com/cucumber/messages/go/v24.PickleStep, *StepDefinition)

# summary
Inferred base version: v0.14.1
Suggested version: v0.15.0

@Johnlon
Copy link
Member

Johnlon commented Oct 12, 2024

do you want help reviewing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants