-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Pydantic v2 #170
Conversation
…-mx/clabe-python into feature/add-editable-banks-config
….10.3, and set version to 2.0.0.dev0
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -20,7 +20,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
python-version: [3.7, 3.8] | |||
python-version: [3.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agregar las versiones hasta la 3.13
@@ -36,3 +38,35 @@ def test_generate_new_clabes(): | |||
for clabe in clabes: | |||
assert clabe.startswith(prefix) | |||
assert validate_clabe(clabe) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
de preferencia no pongas los cambios del otro branch, para que no genere ruido
cuando se mezclen puedes hacer el rebase para que los tengas aplicados pero al ser pr distintos lo correcto es no mezclarlos
Description:
This PR migrates the project to Pydantic v2 and drops support for Python 3.7
Key Changes:
Breaking Changes: