Fix mypy (#12)

* mypy

* typing cast

* ignore __init__

* already fixed this with new version of clabe-python

* version bump

Co-authored-by: Matin Tamizi <[email protected]>

Makefile

@@ -26,7 +26,7 @@ lint:
 	flake8 $(PROJECT) tests setup.py
 	$(isort) --check-only
 	$(black) --check
-#	mypy $(PROJECT) tests
+	mypy $(PROJECT) tests
 
 clean:
 	rm -rf `find . -name __pycache__`

cuenca/resources/api_keys.py

@@ -1,5 +1,5 @@
 import datetime as dt
-from typing import ClassVar, Optional
+from typing import ClassVar, Optional, cast
 
 from pydantic.dataclasses import dataclass
 
@@ -27,7 +27,7 @@ def active(self) -> bool:
 
     @classmethod
     def create(cls) -> 'ApiKey':
-        return cls._create()
+        return cast('ApiKey', cls._create())
 
     @classmethod
     def deactivate(cls, api_key_id: str, minutes: int = 0) -> 'ApiKey':
@@ -40,4 +40,4 @@ def deactivate(cls, api_key_id: str, minutes: int = 0) -> 'ApiKey':
         """
         url = cls._endpoint + f'/{api_key_id}'
         resp = session.delete(url, dict(minutes=minutes))
-        return cls._from_dict(resp)
+        return cast('ApiKey', cls._from_dict(resp))

cuenca/resources/base.py

@@ -12,6 +12,10 @@
 class Resource:
     _endpoint: ClassVar[str]
 
+    def __init__(self, **kwargs):  # pragma no cover
+        for attr, value in kwargs.items():
+            setattr(self, attr, value)
+
     @classmethod
     def _from_dict(cls, obj_dict: Dict[str, Union[str, int]]) -> 'Resource':
         cls._filter_excess_fields(obj_dict)

cuenca/resources/transfers.py

@@ -1,5 +1,5 @@
 import datetime as dt
-from typing import ClassVar, Optional
+from typing import ClassVar, Optional, cast
 
 from clabe import Clabe
 from pydantic import BaseModel, StrictStr
@@ -70,7 +70,7 @@ def create(
             recipient_name=recipient_name,
             idempotency_key=idempotency_key,
         )
-        return cls._create(**req.dict())
+        return cast('Transfer', cls._create(**req.dict()))
 
     @staticmethod
     def _gen_idempotency_key(account_number: str, amount: int) -> str:

cuenca/version.py

@@ -1,3 +1,3 @@
-__version__ = '0.1.3'
+__version__ = '0.1.4'
 CLIENT_VERSION = __version__
 API_VERSION = '2020-03-19'

setup.cfg

@@ -15,4 +15,4 @@ force_grid_wrap=0
 combine_as_imports=True
 
 [mypy-pytest]
-ignore_missing_imports = true
+ignore_missing_imports = True