Upgrade dependencies #196
Upgrade dependencies #196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 10 10
Lines 374 374
Branches 53 53
=======================================
Hits 372 372
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| anyio==4.3.0 | ||
| cuenca-validations==0.11.27 | ||
| fastapi==0.108.0 | ||
| httpx==0.27.0 |
There was a problem hiding this comment.
me parece que httpx es una dependencia para testing
| mongoengine-plus==0.0.3 | ||
| anyio==4.3.0 | ||
| cuenca-validations==0.11.27 | ||
| fastapi==0.108.0 |
There was a problem hiding this comment.
Con esta actualización debemos asegurar que la versión de starlette>=28 de acuerdo a https://github.com/tiangolo/fastapi/releases/tag/0.107.0. Además revisar si la versión de starlette-context no tiene conflictos con una versión más actualizada e starlette
| fastapi==0.68.2 | ||
| mongoengine-plus==0.0.3 | ||
| anyio==4.3.0 | ||
| cuenca-validations==0.11.27 |
There was a problem hiding this comment.
pydantic no tuvo problemas? si si tal vez este prerelease pueda ayudar en algo.Actualiza hasta la última versión de pydantic 1.x https://github.com/cuenca-mx/cuenca-validations/releases/tag/0.11.28.dev0
| @@ -14,12 +14,12 @@ def health_auth_check() -> Dict: | |||
|
|
|||
|
|
|||
| @app.get('/raise_cuenca_errors') | |||
| def raise_cuenca_errors() -> NoReturn: | |||
| def raise_cuenca_errors() -> None: | |||
There was a problem hiding this comment.
según mypy el tipo correcto de retorno es NoReturn
https://mypy.readthedocs.io/en/latest/more_types.html#the-noreturn-type
|
Además, para evitar que hayan errores raros al hacer |
Se actualizan versiones compatibles de fasstapi + starlette + uvicorn y otras despendencias