fixing excess fields on DocumentStep (#119)

* fixing excess fields on DocumentStep

* version

* remove pragma

* fixed

* tested

* eofl

mati/resources/verifications.py

@@ -36,7 +36,8 @@ def __post_init__(self):
         ]
         for doc in self.documents:
             doc['steps'] = [
-                VerificationDocumentStep(**step) for step in doc['steps']
+                VerificationDocumentStep._from_dict(step)
+                for step in doc['steps']
             ]
             docs.append(VerificationDocument(**doc))
         self.documents = docs

mati/types/enums.py

@@ -1,6 +1,6 @@
-from dataclasses import dataclass, field
+from dataclasses import dataclass, field, fields
 from enum import Enum
-from typing import BinaryIO, Dict, List, Optional, Union
+from typing import Any, BinaryIO, Dict, List, Optional, Union
 
 
 class SerializableEnum(str, Enum):
@@ -34,6 +34,19 @@ class VerificationDocumentStep:
     error: Optional[Dict] = None
     data: Optional[Dict] = field(default_factory=dict)
 
+    @classmethod
+    def _filter_excess_fields(cls, obj_dict: Dict) -> None:
+        excess = set(obj_dict.keys()) - {f.name for f in fields(cls)}
+        for f in excess:
+            del obj_dict[f]
+
+    @classmethod
+    def _from_dict(
+        cls, obj_dict: Dict[str, Any]
+    ) -> 'VerificationDocumentStep':
+        cls._filter_excess_fields(obj_dict)
+        return cls(**obj_dict)
+
 
 @dataclass
 class Errors:

mati/version.py

@@ -1 +1 @@
-__version__ = '2.0.4'  # pragma: no cover
+__version__ = '2.0.5'

tests/resources/cassettes/test_retrieve_full_verification.yaml

@@ -108,7 +108,7 @@ interactions:
         "steps": [{"status": 200, "id": "document-reading", "data": {"fullName": {"required":
         true, "label": "Name", "value": "FIRST NAME"}, "address": {"label": "Address",
         "value": "Varsovia 36, 06600 CDMX"}, "emissionDate": {"format": "date", "label":
-        "Emission Date", "value": "1880-01-01"}}, "error": null}, {"status": 200,
+        "Emission Date", "value": "1880-01-01"}}, "error": null, "reused": false, "cacheHit": false}, {"status": 200,
         "id": "watchlists", "error": null}], "fields": {"address": {"value": "Varsovia
         36, 06600 CDMX"}, "emissionDate": {"value": "1880-01-01"}, "fullName": {"value":
         "FIRST LASTNAME"}}, "photos": ["https://media.getmati.com/file?location=xyc"]}],

tests/test_types.py

@@ -2,6 +2,7 @@
 from pytest_lazyfixture import lazy_fixture
 
 from mati.types import ValidationInputType
+from mati.types.enums import VerificationDocumentStep
 
 
 def test_type_to_str():
@@ -31,3 +32,15 @@ def test_type_to_str():
 )
 def test_document_type(verification_document, expected_type):
     assert verification_document.document_type == expected_type
+
+
+def test_from_dict():
+    data = {'some': 'data', 'aditional': 'data', 'id': 'foo', 'status': 10}
+    step = VerificationDocumentStep._from_dict(data)
+    assert step
+
+
+def test_excess_fields():
+    data = {'some': 'data', 'aditional': 'data', 'id': 'foo', 'status': 10}
+    VerificationDocumentStep._filter_excess_fields(data)
+    assert 'some' not in data