Constraint (#116)

* Constraint * capture exception and test * isort * Update views.py * Update views.py * test Co-authored-by: Arturo Pacheco <[email protected]>
cuenca-mx · Apr 15, 2020 · 9b06dab · 9b06dab
1 parent ae2701b
commit 9b06dab
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 6 deletions.
diff --git a/speid/models/transaction.py b/speid/models/transaction.py
@@ -79,6 +79,11 @@ class Transaction(Document, BaseModel):
     iva = StringField()
 
     events = ListField(ReferenceField(Event))
+    meta = {
+        'indexes': [
+            {'fields': ('clave_rastreo', 'fecha_operacion'), 'unique': True}
+        ]
+    }
 
     def set_state(self, state: Estado):
         callback_helper.set_status_transaction(self.speid_id, state.value)

diff --git a/speid/views.py b/speid/views.py
@@ -2,7 +2,7 @@
 import os
 
 from flask import abort, request
-from mongoengine import DoesNotExist
+from mongoengine import DoesNotExist, NotUniqueError
 from sentry_sdk import capture_exception, capture_message
 from stpmex.exc import StpmexException
 
@@ -65,6 +65,9 @@ def create_orden():
 
         r = request.json
         r['estado'] = Estado.convert_to_stp_state(transaction.estado)
+    except (NotUniqueError, AssertionError) as e:
+        r = dict(estado='LIQUIDACION')
+        capture_exception(e)
     except Exception as e:
         r = dict(estado='LIQUIDACION')
         transaction.estado = Estado.error

diff --git a/tests/models/test_transactions.py b/tests/models/test_transactions.py
@@ -1,4 +1,7 @@
+from datetime import datetime
+
 import pytest
+from mongoengine import NotUniqueError
 from pydantic import ValidationError
 from stpmex.types import TipoCuenta
 
@@ -48,6 +51,33 @@ def test_transaction():
     transaction.delete()
 
 
+def test_not_duplicate_transaction():
+    transaction_data = dict(
+        concepto_pago='PRUEBA',
+        institucion_ordenante='646',
+        cuenta_beneficiario='072691004495711499',
+        institucion_beneficiaria='072',
+        monto=1020,
+        nombre_beneficiario='Rogelio Lopez',
+        nombre_ordenante='BANCO',
+        cuenta_ordenante='646180157000000004',
+        rfc_curp_ordenante='ND',
+        speid_id='speid_id',
+        fecha_operacion=datetime.today(),
+        clave_rastreo='abc123',
+    )
+
+    transaction = Transaction(**transaction_data)
+    transaction.save()
+    assert transaction.id is not None
+
+    transaction_duplicated = Transaction(**transaction_data)
+    with pytest.raises(NotUniqueError):
+        transaction_duplicated.save()
+    assert transaction_duplicated.id is None
+    transaction.delete()
+
+
 def test_transaction_stp_input():
     data = dict(
         Clave=2456304,

diff --git a/tests/views/test_general.py b/tests/views/test_general.py
@@ -142,11 +142,9 @@ def test_create_orden_duplicated(
     transactions = Transaction.objects(
         clave_rastreo=default_income_transaction['ClaveRastreo']
     ).order_by('-created_at')
-    assert len(transactions) == 2
-    assert transactions[0].stp_id == 2456304
-    assert transactions[0].estado is Estado.error
-    assert transactions[1].stp_id == 2456303
-    assert transactions[1].estado is Estado.succeeded
+    assert len(transactions) == 1
+    assert transactions[0].stp_id == 2456303
+    assert transactions[0].estado is Estado.succeeded
     assert resp.status_code == 201
     assert resp.json['estado'] == 'LIQUIDACION'
     for t in transactions:
@@ -234,6 +232,7 @@ def test_get_transactions(
     resp = client.get('/transactions')
     assert resp.status_code == 200
     assert len(resp.json) == 2
+    trx_out.delete()
 
 
 @pytest.mark.vcr