-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TP 1 Terminé #4
Open
arthurdeschamps
wants to merge
10
commits into
cui-unige:master
Choose a base branch
from
arthurdeschamps:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TP 1 Terminé #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tats calculation, typeModifier function, damage (two remaining things to implement : the parameter “other” and the “stages” for critical hits probabilities) No bug/logic testing yet, so there might be a lot of code to correct Big todos remaining: battle state and battle
…battle (and track any potential bug or inconsistencie). swift_exercices file greatly improved and probably working without bugs. User’s turn is done, but computer’s turn and actions resolving still need to be done.
… or running away. Still very important things to implement: Switch pokemons and use items (not sure if that will be ever implemented). Powerpoints stay constant for now: that’s the first step for future dev.
Switch pokemons feature added.
…cies. Current bug: computer doesn’t make any action anymore
…revious bug with the opponent not doing his action) Main features are now implemented.
- Nicknames are now randomly chosen for computer’s pokemons (until the number of pokemons reaches the total amount of available names) - Changed type of user_action from Any? To Move?, since it’s wether a move or a nil when the action is resolved immediately - Computer choses the Pokemon with the greatest hitpoints remaining when it comes to make a substitution (or when a Pokemon is dazed) - Random natures are generated for newly created Pokemons (user or computer)
* dev: Done: - Nicknames are now randomly chosen for computer’s pokemons (until the number of pokemons reaches the total amount of available names) - Changed type of user_action from Any? To Move?, since it’s wether a move or a nil when the action is resolved immediately - Computer choses the Pokemon with the greatest hitpoints remaining when it comes to make a substitution (or when a Pokemon is dazed) - Random natures are generated for newly created Pokemons (user or computer) Fix: added missing cases during actions resolving (which causes the previous bug with the opponent not doing his action) Main features are now implemented. Added possibility to choose a custom Pokemon based on an existing species. Current bug: computer doesn’t make any action anymore Moved in init function moves and species definitions. Switch pokemons feature added.
Your code does not compile on the continuous integration platform, because it requires the |
I'm using arc4random_uniform and exit that requires Darwin. I'll try to get rid of them and find a replacement. |
Functions from Darwin (exit and arc4random_uniform) are now defined for linux platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les principales fonctionnalités ainsi que quelques détails sont implémentés. Je n'ai détecté aucun bug jusqu'à maintenant, j'espère qu'il n'y en a pas de caché.
Quelques fonctionnalités importantes:
other
)Fonctionnalités manquantes: