Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support disable_decoding in async read_response #349

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

Redoubts
Copy link
Contributor

Mimics the code in the sync method to also skip decoding when requested.

if kwargs.get("disable_decoding", False):

@Redoubts Redoubts requested a review from cunla as a code owner December 17, 2024 20:01
@cunla
Copy link
Owner

cunla commented Dec 17, 2024

Hi, thanks for this.
Would you mind adding a test for it?

@Redoubts
Copy link
Contributor Author

Had to add to the async_redis fixture, since I needed to have decode_responses enabled to verify I could force-disable it

@cunla cunla merged commit 72e2fa9 into cunla:master Dec 18, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants