feat: AccountApi #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add smart contract base structure
feat(browser-extension): add signing utils test(browser-extension): add signing utils tests
Added working signing with dynamically checked address type test(browser-extension): added simple error throwing test for accountApi
| export const getDomainSeparator = (chainId: number): string => { | ||
| return ethers.utils.keccak256( | ||
| ethers.utils.defaultAbiCoder.encode( | ||
| ["bytes32", "bytes32", "uint256"] as string[], |
| export const getTxnHash = (transaction: Transaction): string => { | ||
| return ethers.utils.keccak256( | ||
| ethers.utils.defaultAbiCoder.encode( | ||
| ["uint256", "uint256", "address", "bool", "uint256", "bytes"] as string[], |
There was a problem hiding this comment.
here and everywhere else too
| }; | ||
|
|
||
| // Get the hash of the given transaction | ||
| export const getTxnHash = (transaction: Transaction): string => { |
There was a problem hiding this comment.
maybe getKeccakHashForTransactionObject
| }; | ||
|
|
||
| // Get the hash of the signed message for the given transaction and chain ID | ||
| export function getTransactionHash( |
There was a problem hiding this comment.
maybe getEip712HashForTransactionObject
| const message = ethers.utils.solidityPack( | ||
| ["bytes2", "bytes32", "bytes32"] as string[], | ||
| [ | ||
| ethers.utils.toUtf8Bytes("\x19\x01"), |
There was a problem hiding this comment.
where is this coming from
There was a problem hiding this comment.
put the magic var into a constant
| ethers.utils.toUtf8Bytes("\x19\x01"), | ||
| domainSeparator, | ||
| getTxnHash(transaction), | ||
| ] as string[], |
chore(pullRequest): refactored tests so they work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add AccountApi object for signing utils.