Merge pull request #35 from tonyk7440/master

Fixing up R CMD Check
curso-r · Jul 2, 2021 · 60aade5 · 60aade5
2 parents bf27cd8 + 722c8df
commit 60aade5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/R/catboost.R b/R/catboost.R
@@ -189,7 +189,7 @@ add_boost_tree_catboost <- function() {
   parsnip::set_model_arg(
     model = "boost_tree",
     eng = "catboost",
-    parsnip = "sample_size",
+    parsnip = "sample_prop",
     original = "subsample",
     func = list(pkg = "dials", fun = "sample_size"),
     has_submodel = FALSE

diff --git a/R/lightgbm.R b/R/lightgbm.R
@@ -166,7 +166,7 @@ add_boost_tree_lightgbm <- function() {
   parsnip::set_model_arg(
     model = "boost_tree",
     eng = "lightgbm",
-    parsnip = "sample_size",
+    parsnip = "sample_prop",
     original = "bagging_fraction",
     func = list(pkg = "dials", fun = "sample_size"),
     has_submodel = FALSE

diff --git a/tests/testthat/helper-model.R b/tests/testthat/helper-model.R
@@ -5,7 +5,7 @@ mtcars_class_binary$vs <- as.factor(mtcars$vs)
 
 expect_all_modes_works <- function(model, engine) {
   if(engine == "lightgbm") {
-    model <- parsnip::set_engine(model, engine, verbosity = -1L)
+    model <- parsnip::set_engine(model, engine)
   } else {
     model <- parsnip::set_engine(model, engine)
   }

diff --git a/vignettes/working-with-lightgbm-catboost.Rmd b/vignettes/working-with-lightgbm-catboost.Rmd
@@ -11,6 +11,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
+  eval = FALSE,
   warning = FALSE,
   message = FALSE
 )