Skip to content

Commit

Permalink
update test for tune. related to #22
Browse files Browse the repository at this point in the history
The test is failing because of sample_size = tune() for lightgbm.
  • Loading branch information
Athospd committed Aug 2, 2020
1 parent e0b6c78 commit a568413
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
10 changes: 9 additions & 1 deletion tests/testthat/test-catboost.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,15 @@ test_that("catboost", {

test_that("catboost with tune", {

model <- parsnip::boost_tree(mtry = 5, trees = tune())
model <- parsnip::boost_tree(
mtry = 5,
learn_rate = tune(),
loss_reduction = tune(),
sample_size = tune(),
trees = tune(),
min_n = tune(),
tree_depth = tune()
)
model <- parsnip::set_engine(model, "catboost")

expect_can_tune_boost_tree(model)
Expand Down
10 changes: 9 additions & 1 deletion tests/testthat/test-lightgbm.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,15 @@ test_that("lightgbm", {

test_that("lightgbm with tune", {

model <- parsnip::boost_tree(mtry = 5, trees = tune())
model <- parsnip::boost_tree(
mtry = 5,
learn_rate = tune(),
loss_reduction = tune(),
sample_size = tune(),
trees = tune(),
min_n = tune(),
tree_depth = tune()
)
model <- parsnip::set_engine(model, "lightgbm")
model <- parsnip::set_mode(model, "regression")

Expand Down

0 comments on commit a568413

Please sign in to comment.