Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trigger shortcut more obscure #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BlueDrink9
Copy link

The current shortcut clashes with some extensions

This seems to work on my linux configuration with codium, whereas the f17 mapping didn't

The current shortcut [clashes with some extensions](cursorless-dev/cursorless#880 (comment))

This seems to work on my linux configuration with codium, whereas the f17 mapping didn't
@BlueDrink9
Copy link
Author

Matches with talonhub/community#1697

@pokey
Copy link
Member

pokey commented Jan 22, 2025

We need to tread carefully here, as this code has been through lots of paces to avoid various issues people have hit over time (eg keyboard layout / OS combos). We should a) test this on a few setups, and b) make sure we don't break backward compatibility, as users tend to update community very infrequently, whereas vscode extension pushes automatically

@BlueDrink9
Copy link
Author

BlueDrink9 commented Jan 22, 2025

That's about what I had hoped for. I can test on linux and windows, but if there are other iterations this has been through, I only saw the last couple.

To be honest, I'd be happy with just knowing how to override this in my own talon scripts

@BlueDrink9
Copy link
Author

Hadn't thought about keyboard layout, but I can see backticks being an issue there

@phillco
Copy link
Member

phillco commented Jan 23, 2025

We need to tread carefully here, as this code has been through lots of paces to avoid various issues people have hit over time (eg keyboard layout / OS combos).

I don't suppose we have a list of those factors, do we? I know the macOS v Windows shortcut is different for a reason but I can't remember why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants