Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkMatchingValues #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

checkMatchingValues #5

wants to merge 1 commit into from

Conversation

a1ex-garofalo
Copy link

No description provided.

demmings
demmings reviewed Aug 3, 2023
View reviewed changes
Copy link

@demmings demmings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your variables should be set using 'const' since none of the variables are re-assigned.
Your for loop should use 'for (const srcVal of sourceValuesFlat)' and replace 'sourceValuesFlat[i]' with srcVal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demmings demmings demmings left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a1ex-garofalo @demmings