Cache the results of #cloudfront_proxies and #trusted_proxies #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were being regenerated each call, which takes several ms. Freeze the results of these methods and #ip_ranges to ensure they don't get accidentally modified by callers. railtie was doing this, inadvertently, so use normal array addition there.
willbryant
force-pushed
the
cache_trusted_proxies
branch
from
4cfc3da to
3cf05b9
Compare
|
This PR is open and inactive for 30 days. Merging PRs open after a long time is error-prone. Please proceed to merging or make a comment to keep it open. You can also prevent PRs from being tagged stale or closed with 'keep-open' tag. If there is no activity in 90 days, this PR will be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were being regenerated each call, which takes several ms.
Freeze the results of these methods and #ip_ranges to ensure they don't get accidentally modified by callers.
Stakeholder Overview (learn more)
Fixes a performance regression we suffered in production trying to filter out Cloudfront IPs from our request IP logging.
Risk Estimate (learn more)
Changes
Caches and freezes the results of the trusted_proxies and cloudfront_proxies methods.
Updated Dependencies