add smime support #104
Open
add smime support #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantti
reviewed
Jul 22, 2024
dantti
reviewed
Jul 22, 2024
for more information, see https://pre-commit.ci
dantti
requested changes
Oct 16, 2024
| bool writeMimeMessageBuffer(); | ||
| bool handleData(PKCS7 *p7, BIO *dataIn, int flags); | ||
|
|
||
| MimeMessage *_mimeMessage; |
There was a problem hiding this comment.
All these members should go into a private class, and I think it would be nicer if we could transform a MimeMessage into a SMimeMessage
| @@ -93,6 +109,7 @@ target_link_libraries(SimpleMail${PROJECT_VERSION_MAJOR}Qt${QT_VERSION_MAJOR} | |||
| PUBLIC | |||
| Qt::Core | |||
| Qt::Network | |||
| ${OPENSSL_LIBS} | |||
There was a problem hiding this comment.
Call target_link_libs() agains instead of variable
| @@ -228,6 +231,10 @@ bool MimePart::write(QIODevice *device) | |||
| headers.append("; name=\"?UTF-8?B?" + d->contentName.toBase64(QByteArray::Base64Encoding) + | |||
| "?=\""); | |||
| } | |||
| if (headers.contains("signed")) { | |||
| headers.append("; protocol=\"application/pkcs7-signature\";"); | |||
| headers.append("; micalg=sha1"); | |||
There was a problem hiding this comment.
put on a single line, it seems to have doubled ;
|
|
||
| int flags = PKCS7_DETACHED | PKCS7_STREAM | PKCS7_BINARY; | ||
|
|
||
| BIO *out = NULL; |
There was a problem hiding this comment.
null, raw pointers, would be nicer if it was RAII even if with just std::unique_ptr with custom deleter
|
|
||
| void SMime::loadPKCS12PrivateKey() | ||
| { | ||
| QFile file(QString::fromLatin1(_keyfile.toStdString().c_str())); |
There was a problem hiding this comment.
no need for all these conversions
|
|
||
| bool SMime::writeMimeMessageBuffer() | ||
| { | ||
| QBuffer *buffer = new QBuffer; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as promised in Pull Request #101, here is SMIME support for the master branch.