Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor code refactor #184

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

chore: minor code refactor #184

wants to merge 6 commits into from

Conversation

jamesgeorge007
Copy link
Contributor

  • Make use of array and object destructuring possibilities.
  • Replace instances of var.
  • Change variable name from opn -> open which makes much sense as per the context.

@maddhruv maddhruv requested a review from bnb December 23, 2019 07:28
@jamesgeorge007 jamesgeorge007 requested review from bnb and hemal7735 and removed request for bnb January 15, 2020 12:26
hemal7735
hemal7735 approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@hemal7735 hemal7735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesgeorge007 jamesgeorge007 requested review from bnb and removed request for bnb February 19, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddhruv maddhruv maddhruv approved these changes

@hemal7735 hemal7735 hemal7735 approved these changes

@bnb bnb Awaiting requested review from bnb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @hemal7735 @maddhruv