Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/figuredbass object #1614

Merged
merged 10 commits into from
Jul 2, 2023
Merged

Feature/figuredbass object #1614

merged 10 commits into from
Jul 2, 2023

Commits on Jun 19, 2023

  1. introduces FiguredBass object and makes some changes to Notation and … 

    …Figures objects
    Moritz Heffter committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    b7ae781 View commit details
    Browse the repository at this point in the history

  2. indentation update

    Moritz Heffter committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    94f76b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. corrections to notation PR cuthbertLab#1614

    Moritz Heffter committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d6ee784 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. added requested changes to figuredbass and notation object

    Moritz Heffter committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7b099f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. first commit for fixing issues in place.

    @mscuthbert
    mscuthbert committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    c4609bf View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. move FiguredBass object to figuredBass.FiguredBass

    @mscuthbert
    mscuthbert committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    c847113 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/1614

    @mscuthbert
    mscuthbert committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    2672974 View commit details
    Browse the repository at this point in the history

  3. lint and mypy

    @mscuthbert
    mscuthbert committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    70f9f2c View commit details
    Browse the repository at this point in the history

  4. Cover uncovered test lines. https://coveralls.io/builds/60910555 

    Check for what is not being covered by tests when adding new features please.
    @mscuthbert
    mscuthbert committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    f232f9d View commit details
    Browse the repository at this point in the history

  5. reuse your setters, Myke!

    @mscuthbert
    mscuthbert committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    88b8ed9 View commit details
    Browse the repository at this point in the history