Adding K30 Support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvuchener
reviewed
Oct 23, 2018
There was a problem hiding this comment.
If the K30 is the same as the K40, simply add its ID in the K40Device set. Otherwise, don't copy the part that don't apply.
The only exception is testing the SW macro mode, since I'm not sure how to verify that.
In SW mode, the keyboard should send the special keycode when a G-key is pressed instead of the saved macro.
| SetBacklightColorMode = 56, | ||
| SetBacklightAnimation = 49, | ||
| DoCycleAnimation = 52, | ||
| }; |
There was a problem hiding this comment.
You are not using most of those. Are you sure about the request codes, or is it just copied from the K40 codes?
| uint8_t unk3; | ||
| uint8_t color_mode; | ||
| } __attribute__ ((packed)); | ||
| }; |
There was a problem hiding this comment.
Same here. You don't use the color parts and they looks copied from the K40 status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will add K30 support to this tool. I've tested each feature and they all work, including setting hardware macros G1-6. The only exception is testing the SW macro mode, since I'm not sure how to verify that.