-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Illumination Light control interface for HID++ 2.0 #34
base: master
Are you sure you want to change the base?
Conversation
Just the power on/off is implemented for now. Documented in x1990_illumination_v1.pdf in: https://drive.google.com/drive/folders/0BxbRzx7vEV7eWmgwazJ3NUFfQ28
Tested through USB and Bluetooth |
USB:
Bluetooth:
|
ec68745
to
2ad1d20
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2ad1d20
to
cd0a7fd
Compare
It compiles and works on my system, yay. |
With Logitech Litra Glow:
So all seems fine with this model. The last call had an invalid function id but this seems expected given the PR description. Will do a similar test with the Litra Beam later. |
The Litra Glow doesn't support a different effective maximum brightness, so return 0 as the value for that variable as it “[signifies] that there is no effective maximum brightness in effect”.
Looks like the Litra Glow doesn't have a "max effective" brightness. I think the commit I added should let the Have you tried the |
Okay I'll try it soon.
I didn't test it, but this is what it outputs:
This is without the latest commit. So I think it's working fine. |
With the latest commit:
I think it fixed it! |
Just the power on/off is implemented for now.
Documented in x1990_illumination_v1.pdf in:
https://drive.google.com/drive/folders/0BxbRzx7vEV7eWmgwazJ3NUFfQ28