Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC-620: Remove route53 usage #402

Merged
merged 2 commits into from
May 26, 2024
Merged

POC-620: Remove route53 usage #402

merged 2 commits into from
May 26, 2024

Conversation

pelegor
Copy link
Collaborator

@pelegor pelegor commented May 26, 2024

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@pelegor pelegor changed the title POC-620: Remove route53 ussage POC-620: Remove route53 usage May 26, 2024
@pelegor pelegor merged commit fdede7e into develop May 26, 2024
1 check passed
@pelegor pelegor deleted the POC-620 branch May 26, 2024 10:17
pelegor added a commit that referenced this pull request May 27, 2024
* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request May 27, 2024
* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request May 27, 2024
* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request Jun 18, 2024
* POC-999-update-release-version

* POC-584: update runtime

* Update to RHEL 9 (#397)

* POC-634: Create GitHub Action (#400)

* POC-620: Remove route53 usage (#402)

* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>

* POC-684: Delete AIO template (#403)

* POC-620: remove route53 from changelog

* POC-620: remove hosted zone creation

* update to v14.2 (#404)

* update changelog

* update readme

* rephrase

* .

* typos

---------

Co-authored-by: ggalfrin <[email protected]>
Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request Jun 18, 2024
* POC-999-update-release-version

* POC-584: update runtime

* Update to RHEL 9 (#397)

* POC-634: Create GitHub Action (#400)

* POC-620: Remove route53 usage (#402)

* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>

* POC-684: Delete AIO template (#403)

* POC-620: remove route53 from changelog

* POC-620: remove hosted zone creation

* update to v14.2 (#404)

* update changelog

* update readme

* rephrase

* .

* typos

* refactor indents

---------

Co-authored-by: ggalfrin <[email protected]>
Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request Jun 18, 2024
* POC-999-update-release-version

* POC-584: update runtime

* Update to RHEL 9 (#397)

* POC-634: Create GitHub Action (#400)

* POC-620: Remove route53 usage (#402)

* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>

* POC-684: Delete AIO template (#403)

* POC-620: remove route53 from changelog

* POC-620: remove hosted zone creation

* update to v14.2 (#404)

* update changelog

* update readme

* rephrase

* .

* typos

* refactor indents

* fix indents

---------

Co-authored-by: ggalfrin <[email protected]>
Co-authored-by: ggalfrin <[email protected]>
pelegor added a commit that referenced this pull request Jun 18, 2024
* POC-999-update-release-version

* POC-584: update runtime

* Update to RHEL 9 (#397)

* POC-634: Create GitHub Action (#400)

* POC-620: Remove route53 usage (#402)

* POC-620 remove dns from full-pas

* remove DNS

---------

Co-authored-by: ggalfrin <[email protected]>

* POC-684: Delete AIO template (#403)

* POC-620: remove route53 from changelog

* POC-620: remove hosted zone creation

* update to v14.2 (#404)

* update changelog

* update readme

* rephrase

* .

* typos

* fix indents

---------

Co-authored-by: ggalfrin <[email protected]>
Co-authored-by: ggalfrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants