-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC-620: Remove route53 usage #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelegor
added a commit
that referenced
this pull request
May 27, 2024
* POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
May 27, 2024
* POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
May 27, 2024
* POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
Jun 18, 2024
* POC-999-update-release-version * POC-584: update runtime * Update to RHEL 9 (#397) * POC-634: Create GitHub Action (#400) * POC-620: Remove route53 usage (#402) * POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]> * POC-684: Delete AIO template (#403) * POC-620: remove route53 from changelog * POC-620: remove hosted zone creation * update to v14.2 (#404) * update changelog * update readme * rephrase * . * typos --------- Co-authored-by: ggalfrin <[email protected]> Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
Jun 18, 2024
* POC-999-update-release-version * POC-584: update runtime * Update to RHEL 9 (#397) * POC-634: Create GitHub Action (#400) * POC-620: Remove route53 usage (#402) * POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]> * POC-684: Delete AIO template (#403) * POC-620: remove route53 from changelog * POC-620: remove hosted zone creation * update to v14.2 (#404) * update changelog * update readme * rephrase * . * typos * refactor indents --------- Co-authored-by: ggalfrin <[email protected]> Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
Jun 18, 2024
* POC-999-update-release-version * POC-584: update runtime * Update to RHEL 9 (#397) * POC-634: Create GitHub Action (#400) * POC-620: Remove route53 usage (#402) * POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]> * POC-684: Delete AIO template (#403) * POC-620: remove route53 from changelog * POC-620: remove hosted zone creation * update to v14.2 (#404) * update changelog * update readme * rephrase * . * typos * refactor indents * fix indents --------- Co-authored-by: ggalfrin <[email protected]> Co-authored-by: ggalfrin <[email protected]>
pelegor
added a commit
that referenced
this pull request
Jun 18, 2024
* POC-999-update-release-version * POC-584: update runtime * Update to RHEL 9 (#397) * POC-634: Create GitHub Action (#400) * POC-620: Remove route53 usage (#402) * POC-620 remove dns from full-pas * remove DNS --------- Co-authored-by: ggalfrin <[email protected]> * POC-684: Delete AIO template (#403) * POC-620: remove route53 from changelog * POC-620: remove hosted zone creation * update to v14.2 (#404) * update changelog * update readme * rephrase * . * typos * fix indents --------- Co-authored-by: ggalfrin <[email protected]> Co-authored-by: ggalfrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security