Fix dependency #63
Merged
Fix dependency #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukicdarkoo
reviewed
Jan 14, 2025
snapcraft.yaml
Outdated
Comment on lines
107
to
113
| ./scripts/install/linux_runtime_dependencies.sh | ||
| pip3 install --no-input aqtinstall | ||
| export PATH="$PATH:$HOME/.local/bin" | ||
| sudo apt update | ||
| sudo apt install -y lsb-release python3-distro | ||
| sudo apt install python3-distro | ||
| pip3 install distro |
There was a problem hiding this comment.
Suggested change
| ./scripts/install/linux_runtime_dependencies.sh | |
| pip3 install --no-input aqtinstall | |
| export PATH="$PATH:$HOME/.local/bin" | |
| sudo apt update | |
| sudo apt install -y lsb-release python3-distro | |
| sudo apt install python3-distro | |
| pip3 install distro | |
| ./scripts/install/linux_runtime_dependencies.sh | |
| pip3 install --no-input aqtinstall | |
| sudo apt update | |
| sudo apt install -y lsb-release python3-distro | |
| sudo apt install python3-distro | |
| pip3 install distro |
@MNikoliCC Can we check if these dependencies are necessary? For example, lsb-release was present, but the paths were not properly configured.
There was a problem hiding this comment.
I reviewed the dependencies and removed the unnecessary ones, including lsb-release. It should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6729 by resolving the identified dependency problem and handling subsequent issues that arise.