-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modified a production QUnit to exclude debug messages. Modified SCOBotBase to return true when debug is disabled. This conflicted with some SCOBot features that were responding false when true was expected. Modified a SCOBot Production QUnit test modified to no longer trace errors. Results in a quicker QUnit by 30-50ms. Updated dates
- Loading branch information
1 parent
aad38c0
commit 785d28a
Showing
8 changed files
with
1,343 additions
and
28 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,16 +34,16 @@ | |
* @event exception, load, unload, message, continue, comments_lms | ||
* | ||
* @author Cybercussion Interactive, LLC <[email protected]> | ||
* @license Copyright (c) 2009-2014, Cybercussion Interactive LLC | ||
* @license Copyright (c) 2009-2015, Cybercussion Interactive LLC | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
* @requires SCOBotBase, SCOBotUtil | ||
* @version 4.0.4 | ||
* @param options {Object} override default values | ||
* @constructor | ||
*/ | ||
/*! | ||
* SCOBot, Updated July 23rd, 2014 | ||
* Copyright (c) 2009-2014, Cybercussion Interactive LLC. All rights reserved. | ||
* SCOBot, Updated jan 3rd, 2015 | ||
* Copyright (c) 2009-2015, Cybercussion Interactive LLC. All rights reserved. | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
*/ | ||
function SCOBot(options) { | ||
|
@@ -54,7 +54,7 @@ function SCOBot(options) { | |
defaults = { | ||
version: "4.0.5", | ||
createDate: "04/07/2011 09:33AM", | ||
modifiedDate: "12/08/2014 01:24PM", | ||
modifiedDate: "01/03/2014 14:12PM", | ||
prefix: "SCOBot", | ||
// SCOBot default parameters | ||
launch_data: {}, | ||
|
@@ -361,7 +361,7 @@ function SCOBot(options) { | |
scorm.debug(settings.prefix + ": Developer, you're not passing a array type for sequencing/choice. I got " + typeof value + " instead\n" + JSON.stringify(value), 1); | ||
value = ''; | ||
} | ||
/* falls through */ | ||
/* falls through */ | ||
case 'sequencing': | ||
// 2004 a[,]b and in 1.2 this was a alpha numeric string: Diagnosis SCORM 2004 format is fine. | ||
if (Utl.isArray(value)) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,15 +35,15 @@ | |
* @event debug, getvalue, setvalue, exception, terminated, StoreData | ||
* | ||
* @author Cybercussion Interactive, LLC <[email protected]> | ||
* @license Copyright (c) 2009-2014, Cybercussion Interactive LLC | ||
* @license Copyright (c) 2009-2015, Cybercussion Interactive LLC | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
* @version 4.0.3 | ||
* @param options {Object} override default values | ||
* @constructor | ||
*/ | ||
/*! | ||
* SCOBotBase, Updated July 23rd, 2014 | ||
* Copyright (c) 2009-2014, Cybercussion Interactive LLC. | ||
* SCOBotBase, Updated Jan 3rd, 2015 | ||
* Copyright (c) 2009-2015, Cybercussion Interactive LLC. | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
*/ | ||
function SCOBotBase(options) { | ||
|
@@ -54,7 +54,7 @@ function SCOBotBase(options) { | |
defaults = { | ||
version: "4.0.5", | ||
createDate: "04/05/2011 08:56AM", | ||
modifiedDate: "12/08/2014 01:23PM", | ||
modifiedDate: "01/03/2015 14:12PM", | ||
debug: false, | ||
isActive: false, | ||
throw_alerts: false, | ||
|
@@ -152,7 +152,7 @@ function SCOBotBase(options) { | |
if (lvl < 3 && settings.throw_alerts) { | ||
alert(msg); | ||
} | ||
return false; | ||
return true; // altered Jan 3rd, 2015 - this conflicted with debugging off on setObjective for QUnit test | ||
} | ||
|
||
/** | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,22 +42,22 @@ | |
* https://github.com/cybercussion/SCOBot | ||
* | ||
* @author Cybercussion Interactive, LLC <[email protected]> | ||
* @license Copyright (c) 2009-2014, Cybercussion Interactive LLC | ||
* @license Copyright (c) 2009-2015, Cybercussion Interactive LLC | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
* @version 4.0.5 | ||
* @constructor | ||
*/ | ||
/*! | ||
* SCOBot Utility, Updated July 23rd, 2014 | ||
* Copyright (c) 2009-2013, Cybercussion Interactive LLC. All rights reserved. | ||
* SCOBot Utility, Updated Jan 3rd, 2015 | ||
* Copyright (c) 2009-2015, Cybercussion Interactive LLC. All rights reserved. | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
*/ | ||
var SCOBotUtil = function () { | ||
// Constructor /////////////// | ||
"use strict"; | ||
var version = "1.0.4", | ||
createDate = "07/23/2013 03:23PM", | ||
modifiedDate = "12/8/2014 02:16PM", | ||
modifiedDate = "01/03/2015 14:12PM", | ||
isReady = false, | ||
types = ["Boolean", "Number", "String", "Function", "Array", "Date", "RegExp", "Object"], | ||
class_types = [], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,26 +18,26 @@ | |
* @event StoreData | ||
* | ||
* @author Cybercussion Interactive, LLC <[email protected]> | ||
* @license Copyright (c) 2009-2014, Cybercussion Interactive LLC | ||
* @license Copyright (c) 2009-2015, Cybercussion Interactive LLC | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
* @requires SCOBotUtil, SCOBotBase | ||
* @version 4.0.0 | ||
* @param options {Object} override default values | ||
* @constructor | ||
*/ | ||
/*! | ||
* Local_API_1484_11, Updated January 3rd, 2014 | ||
* Copyright (c) 2009-2014, Cybercussion Interactive LLC. | ||
* Local_API_1484_11, Updated January 3rd, 2015 | ||
* Copyright (c) 2009-2015, Cybercussion Interactive LLC. | ||
* As of 3.0.0 this code is under a Creative Commons Attribution-ShareAlike 4.0 International License. | ||
*/ | ||
function SCOBot_API_1484_11(options) { | ||
// Constructor | ||
"use strict"; | ||
var Utl = SCOBotUtil, | ||
defaults = { | ||
version: "4.0.0", | ||
version: "4.0.5", | ||
createdate: "07/17/2010 08:15AM", | ||
moddate: "07/24/2014 10:34PM", | ||
moddate: "01/03/2015 14:12PM", | ||
prefix: "SCOBot_API_1484_11", | ||
errorCode: 0, | ||
diagnostic: '', | ||
|
Oops, something went wrong.