Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "long term statistics" categories #198

Closed
wants to merge 1 commit into from

Conversation

jfparis
Copy link
Contributor

@jfparis jfparis commented Oct 18, 2024

HASS long-term statistics require sensors to have a state_class argument. Nearly all the sensors were set as "total". Some such as heart rates, respiration rates and percentage statistics are better suited to be treated as point in time "measurement"

HASS long term statistics require sensors have a state_class
argument. Nearly all the sensors were set as "total". Some such as
heart rates, respiration rates and percentage statistics are better
suited to be treated as point in timne "measurement"
@jfparis jfparis closed this Nov 27, 2024
@cyberjunky
Copy link
Owner

@jfparis I didn't forgot this one, but why closed, not needed anymore?

@cyberjunky
Copy link
Owner

OH I see you created a PR, even better, thanks! Will follow up later today!

@cyberjunky
Copy link
Owner

#203

@cyberjunky cyberjunky reopened this Nov 28, 2024
@jfparis
Copy link
Contributor Author

jfparis commented Nov 28, 2024

Yes. New PR
I would drop that one (which also includes some formatting)

If you want to do the isort/ black formatting, should probably do that for whole code and in a different PR

@cyberjunky
Copy link
Owner

Closing because of newer PR.

@cyberjunky cyberjunky closed this Dec 17, 2024
@jfparis jfparis deleted the measurement_units branch January 13, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants