Rip out vector mapfile setting #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's causing crashes on some phones, and will be replaced with a new mechanism soon, see PR #417.
jezhiggins
changed the title
| } | ||
|
|
||
| private fun setAccountSummary() { | ||
| private fun setAccountSummary() { |
There was a problem hiding this comment.
I think you've accidentally de-indented this by 1 character 😂
I clearly don't care enough to request a change, but you may feel like fixing it as part of your broader PR.
|
@jezhiggins the only possible issue I can see is: what if someone already has vector maps selected as their preference, and then they upgrade to this version? What will happen then? |
|
It should fallback to the default renderer. In fact it will have already done that as it wouldn't be able to open the map file. |
oliverlockwood
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436.
It's causing crashes on some phones, and will be replaced with a new
mechanism soon, see PR #417.