Rework the tunnel and bridge layers for better performance #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling the project to a Mapnik XML file was taking a lot of time, mainly due to the tunnel and bridge layers. Here are some fixes to improve compilation time. * Use attachments for tunnels and bridges instead of selecting all the data three times from the database and filtering on it. * Rework the filtering in `roads.mss` file to avoid having too many levels of imbrication, responsible for a lot of overhead at compilation. * Remove the upper zoom limit as there is no reason to stop displaying the roads above zoom 20. Before this PR, compilation time obtained through ``` \time carto cyclosm-cartocss-style/project.mml > /dev/null ``` was of about 5 minutes. It is now of 24 seconds. Fixes cyclosm#60.
|
Je valide |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Florimondable This is changing quite a lot of lines of code for the render of tunnels and bridges. I did some checks in places I know, but I could definitely use a second pair of eyes on this. Could you check that the render is the same as the current one for bridges and tunnels you are familiar with? Thanks!
Compiling the project to a Mapnik XML file was taking a lot of time,
mainly due to the tunnel and bridge layers. Here are some fixes to
improve compilation time.
data three times from the database and filtering on it.
roads.mssfile to avoid having too manylevels of imbrication, responsible for a lot of overhead at compilation.
the roads above zoom 20.
Before this PR, compilation time obtained through
was of about 5 minutes.
It is now of 24 seconds.
Fixes #60.