Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Calculations Frontend : Version 1.0 #33

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anchalm03
Copy link
Contributor

There are a few problems that I am still trying to figure out:

  1. Dynamic table for **input, charge, multiplicity, ** which allows user to upload as many number of files as user wants.
  2. I am unable to understand about the dependencies of Theory Level parameter special, as given in frontend/calc_form_body.html (line number 287-337)
  3. The elements from Driver onward are not aligned, and its tough to understand how can that be resolved.
  4. Difficulty in hosting new files on the server. (Changes made in the base.html are visible but the code in the new files is not)

Thank You.

@RaphaelRobidas RaphaelRobidas changed the base branch from master to develop June 26, 2023 17:11
@RaphaelRobidas
Copy link
Collaborator

Hello Anchal,

There isn't a new view for the batch calculation page in this PR. Did forget to include it? Or how are you viewing the page?

Also, I quickly created a view to render your page and there are some errors in the Javascript console. This may break some scripts and cause the weird layout of your point 3.

I noticed that you created copies of calc_form_body and calc_form_head. It would be best to reuse the same files in order to have a single form to maintain. It is a bit trickier to code, but should work. Instead of having a "Submit" button, it could be an "Add" button which parses the form data, stores it in local memory, and clears the form.

Reusing the same form would solve point 2, as you shouldn't have to worry about the conditions behind each field. You could modify calc_form_body and calc_form_head and use a is_batch flag in order to add or omit certain elements. This is used with is_flowchart at the moment.

For your point 4: when you modify HTML files, the changes aren't reloaded automatically by default. You can force a template reload by resaving views.py; on Linux, you can use touch frontend/views.py to force the reload without actually modifying views.py.

If you modify backend code used in services other than web (like code in tasks.py), you need to close and reopen CalcUS (i.e., the running Docker-Compose instance) in order to have the new version running.

I hope that helps a bit!

@RaphaelRobidas RaphaelRobidas force-pushed the develop branch 4 times, most recently from 243a8b3 to 21c89eb Compare October 8, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants