Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #14

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

v2.0.0 #14

wants to merge 15 commits into from

Conversation

MaxGfeller
Copy link
Contributor

This is the draft PR for v2.0.0. The new changes can be seen in the CHANGELOG.md.

Here are the things that still have to be done:

  • Handle literals in script blocks
  • Fix coding style issues
  • Fix failing tests
  • Make it possible to not translate a specific string in interactive mode, e.g. by pressing Esc

@Znarkus
Copy link

Znarkus commented Mar 16, 2022

Tested this on Node v16.13.1 in my project.
I get crashes on these lines:

  • vue-translation-manager/src/index.js:159
  • vue-translation-manager/src/util.js:17:23

It seems that it assumes that node.value is always string, and doesn't handle numbers, boolean etc.
Might this be a change in recent NodeJS?

It's trying to do trimStart() on this node.value:

<ref *2> Node {
  type: 'Literal',
  value: true,

and trim() on this:

<ref *2> Node {
  type: 'Literal',
  value: 1,
  raw: '1',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants