-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cargokit for builds, generate Rust->C FFI bindings, and use official sources #61
Draft
sneurlax
wants to merge
55
commits into
main
Choose a base branch
from
official-sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking lib into smaller, better-organized pieces.
TODO remove/make debug prints conditional/situational (to eg. debug runs)
functionality to be re-added via irondash/cargokit
git-subtree-dir: cargokit git-subtree-split: 918f28083f9ef24ce08b9e90d2c46e6a52812d5d
added in previous merge commit as in `git subtree add --prefix cargokit https://github.com/irondash/cargokit.git main --squash` IAW https://matejknopp.com/post/flutter_plugin_in_rust_with_no_prebuilt_binaries/
on underscores. TODO rename to epic_wallet_ffi anyways.
git-subtree-dir: rust git-subtree-split: f4bd572a649598553692efeb2aa17984f0d78b5d
Used `git subtree add --prefix rust https://github.com/cypherstack/epic-ffi.git main --squash` To push subtree changes upstream: 1. Make and commit your changes in the 'rust' directory. 2. Run: git subtree push --prefix rust https://github.com/cypherstack/epic-ffi.git main 2b8c2a,cf4f13
blacktyger/epic-wallet-rust-lib is a fork of cypherstack/flutter_libepiccash, so I couldn't just fork it as usual (as cypherstack/flutter_libepiccash of course already exists). So this is a copy thereof
git-subtree-dir: rust/epic-wallet git-subtree-split: 03fc494409742e001d2389f4f80b3389a80d7263
…-wallet' Added as in `git subtree add --prefix=rust/epic-wallet https://github.com/EpicCash/epic-wallet.git master --squash` Subtree maintenance: - Add a subtree: `git subtree add --prefix=<subdir> <remote-url> <branch> --squash` - Change a subtree’s remote (update from URL A to URL B): Instead of relying on stored remotes, explicitly reference the new URL: `git subtree pull --prefix=<subdir> <new-url> <branch> --squash` (If needed, add a named remote first: `git remote add <new-remote> <new-url>`) - Remove a subtree: `git rm -r <subdir>` (Optionally, remove the remote: `git remote remove <remote>`)
git-subtree-dir: rust/epic git-subtree-split: 07fa6e3c13d969c6fe4268253410359cac59666b
Added as in `git subtree add --prefix=rust/epic https://github.com/EpicCash/epic.git master --squash`
git-subtree-dir: rust/epicbox git-subtree-split: 9ab9409fcdeb19428d8ffdc2a6e307a817ef7e6c
…box' Added as in `git subtree add --prefix=rust/epicbox https://github.com/cypherstack/epicbox.git main --squash`
TODO: push to cypherstack/epicboxlib repo
07d2764
to
1d45e45
Compare
9021909
to
47ae743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes:
(each of the above represents a working checkpoint and improvement upon the status quo in
main
)Added EpicCash/epic, EpicCash/epic-wallet, and cypherstack/epicbox as git subtrees and used each
To do:
cargo test
Optionally:
Sub-issues:
stack_epic_*
Closes #15