Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 action not working in windows or with pnpm #572

Closed
wants to merge 1 commit into from

Conversation

stormslowly
Copy link

why not working with windows when install == false

action export the CYPRESS_CACHE_FOLDER env variable, so cli can not find the binary to execute; but binary is already installed by package manager in another cache folder( (ref)[https://docs.cypress.io/guides/references/advanced-installation#Binary-cache], so according the link, it will ethier not working on mac os)

solution

don't export the env variable, if cypress bin is not installted by the action

why not working with pnpm when install == true

after install action will generate hash from yarn.lock or npm-lock.json, but pnpm dont generate these two files.

solution

user specify the hash file, it will be flexiable to working with new locking files.

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2022

CLA assistant check
All committers have signed the CLA.

@stormslowly
Copy link
Author

stormslowly commented Jun 30, 2022

@admah do you have some comments on this pr ?
could you plz approve the workflow

@MikeMcC399
Copy link
Collaborator

Hi @stormslowly

I was looking at your PR and trying to understand it. It looks like there are some inconsistencies using install-only on Windows. Are you still interested in working on this?

If yes, then I would suggest trying to write up a reproducible example of the issue, then when that is clear, looking at the best way to resolve it.

You proposed some changes in this PR, however they are incomplete. You would need to add some documentation and you would need to re-build the action as well. Also, as quite some time has passed since you submitted the PR, you would need to rebase it on the current master branch. For the time-being, and assuming that you are still interested, I would suggest that you put your PR into draft state.

@stormslowly stormslowly marked this pull request as draft February 2, 2023 07:33
@MikeMcC399
Copy link
Collaborator

@stormslowly

Thanks for putting your PR into a draft state, however it is now three months ago and I haven't seen a reproducible example of the problem yet. Also your branch is > 200 commits behind the master branch.

It may be time to just close this now and revisit if you have time at a later stage.

@MikeMcC399
Copy link
Collaborator

@stormslowly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants