-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding in information on running firefox in a container in the README #938
docs: adding in information on running firefox in a container in the README #938
Conversation
Ran into an issue with running tests in a container with firefox. Googling around led me to this: cypress-io/cypress-docker-images#85 (comment) Firefox cannot be ran as root, and the images are ran as root, so folks will need to specify a non-root user to make this work properly.
|
|
Please refer also to CONTRIBUTING. The commit message and PR subject should start with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown syntax and grammar should be corrected.
There are some other suggestions I added in-line.
I'm wondering if this can be better covered directly in the Cypress Docker repo with a link from here into the main Cypress Docker repo (cypress-docker-images
).
Also since --user 1001
seems to work not only for Firefox, but also for Chrome and Edge, could this just be documented as the standard way to use a Cypress Docker image in GitHub Actions? Or are there some negative side-effects to doing this? If --user 1001
can be used for all browsers then it wouldn't need a special example for Firefox. You could just say --user 1001
is required for Firefox and optional for other browsers.
I'm currently using 1001 for all browsers since I found it wasn't needed to add in an However, my project is just one use-case, and there may be other use cases where passing in that |
Hi @alexjyong 👋, thanks for taking the time to open this PR. I agree with @MikeMcC399 above and think that this documentation should probably be in the |
Sure thing. I'm away from my workstation ATM but I'll be sure to do that.
…On Tue, Jun 13, 2023, 6:02 PM Matt Schile ***@***.***> wrote:
Hi @alexjyong <https://github.com/alexjyong> 👋, thanks for taking the
time to open this PR. I agree with @MikeMcC399
<https://github.com/MikeMcC399> above
<#938 (comment)>
and think that this documentation should probably be in the
cypress-docker-images repo. Would you be willing to open a PR over there
to resolve cypress-io/cypress-docker-images#871
<cypress-io/cypress-docker-images#871>?
—
Reply to this email directly, view it on GitHub
<#938 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJWCVFLEXU3WLSRMVWDBSLXLDPOFANCNFSM6AAAAAAY6OMTWE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@mschile and @MikeMcC399 , I have created a PR here for your review. 😀 |
Hi @alexjyong Thank you so much for your contributions in this area! In the meantime I've had some other interactions with users having difficulties with the Docker images and I have now suggested to make some changes to the README > Docker image example which don't involve adding an extra example for Firefox. You also confirmed that I still have some questions about self-hosted runners, where users have reported issues. That is up in the air because the users who reported the issues did not follow through in detail and I don't have a self-hosted runner to test on. |
|
This PR in particular? If nothing else, I can close this out unless we want to poke at something else? |
https://github.com/cypress-io/github-action#docker-image is now updated. It does not specifically refer to Firefox, instead it recommends always using Thanks once again! |
Resolved in cypress-io/cypress-docker-images#900 |
Ran into an issue with running tests in a container with firefox.
Googling around led me to this:
cypress-io/cypress-docker-images#85 (comment)
Firefox cannot be ran as root, and the images are ran as root, so folks will need to specify a non-root user to make this work properly.