Fix lint

custom_components/bbox/binary_sensor.py

@@ -2,22 +2,31 @@
 
 from __future__ import annotations
 
-import logging
+from collections.abc import Callable
+from dataclasses import dataclass
 
 from homeassistant.components.binary_sensor import (
     BinarySensorDeviceClass,
     BinarySensorEntity,
+    BinarySensorEntityDescription,
 )
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
+from homeassistant.helpers.typing import StateType
 
 from . import BBoxConfigEntry
 from .entity import BboxEntity
-from .helpers import BboxBinarySensorDescription, finditem
+from .helpers import finditem
 
-_LOGGER = logging.getLogger(__name__)
 
-SENSOR_TYPES: tuple[BboxBinarySensorDescription, ...] = (
+@dataclass(frozen=True)
+class BboxBinarySensorDescription(BinarySensorEntityDescription):
+    """Describes a sensor."""
+
+    value_fn: Callable[..., StateType] | None = None
+
+
+BINARIES_SENSORS: tuple[BboxBinarySensorDescription, ...] = (
     BboxBinarySensorDescription(
         key="info.device.status",
         name="Link status",
@@ -33,7 +42,7 @@ async def async_setup_entry(
     """Set up sensor."""
     coordinator = entry.runtime_data
     entities = [
-        BboxBinarySensor(coordinator, description) for description in SENSOR_TYPES
+        BboxBinarySensor(coordinator, description) for description in BINARIES_SENSORS
     ]
     async_add_entities(entities)
 

custom_components/bbox/device_tracker.py

@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import logging
 from typing import Any
 
 from homeassistant.components.device_tracker import SourceType
@@ -15,8 +14,6 @@
 from .coordinator import BboxDataUpdateCoordinator
 from .entity import BboxDeviceEntity
 
-_LOGGER = logging.getLogger(__name__)
-
 
 async def async_setup_entry(
     hass: HomeAssistant, entry: BBoxConfigEntry, async_add_entities: AddEntitiesCallback
@@ -36,7 +33,6 @@ async def async_setup_entry(
 class BboxDeviceTracker(BboxDeviceEntity, ScannerEntity):
     """Representation of a tracked device."""
 
-    _attr_has_entity_name = True
     _attr_entity_registry_enabled_default = False
 
     def __init__(

custom_components/bbox/entity.py

@@ -2,7 +2,6 @@
 
 from __future__ import annotations
 
-import logging
 from typing import Any
 
 from homeassistant.const import CONF_HOST
@@ -15,8 +14,6 @@
 from .coordinator import BboxDataUpdateCoordinator
 from .helpers import finditem
 
-_LOGGER = logging.getLogger(__name__)
-
 
 class BboxEntity(CoordinatorEntity[BboxDataUpdateCoordinator], Entity):
     """Base class for all Bbox entities."""

custom_components/bbox/helpers.py

@@ -2,35 +2,18 @@
 
 from __future__ import annotations
 
-from collections.abc import Callable
-from dataclasses import dataclass
 from typing import Any
 
-from homeassistant.components.binary_sensor import BinarySensorEntityDescription
-from homeassistant.components.sensor import SensorEntityDescription
-from homeassistant.helpers.typing import StateType
-
-
-@dataclass(frozen=True)
-class BboxSensorDescription(SensorEntityDescription):
-    """Describes a sensor."""
-
-    get_value: Callable[..., Any] | None = None
-    value_fn: Callable[..., StateType] | None = None
-
-
-@dataclass(frozen=True)
-class BboxBinarySensorDescription(BinarySensorEntityDescription):
-    """Describes a sensor."""
-
-    value_fn: Callable[..., StateType] | None = None
-
 
 def finditem(data: dict[str, Any], key_chain: str, default: Any = None) -> Any:
     """Get recursive key and return value.
 
     data is a mandatory dictonnary
     key , string with dot for key delimited (ex: "key.key.key")
+
+    It is possible to integrate an element of an array by indicating its index number
+    {"a":{"b":[{"c":"value"}]}
+    key = a.b.0.c
     """
     if (keys := key_chain.split(".")) and isinstance(keys, list):
         for key in keys:

custom_components/bbox/sensor.py

@@ -2,11 +2,14 @@
 
 from __future__ import annotations
 
-import logging
+from collections.abc import Callable
+from dataclasses import dataclass
+from typing import Any
 
 from homeassistant.components.sensor import (
     SensorDeviceClass,
     SensorEntity,
+    SensorEntityDescription,
     SensorStateClass,
 )
 from homeassistant.const import (
@@ -18,12 +21,20 @@
 )
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
+from homeassistant.helpers.typing import StateType
 
 from . import BBoxConfigEntry
 from .entity import BboxEntity
-from .helpers import BboxSensorDescription, finditem
+from .helpers import finditem
+
+
+@dataclass(frozen=True)
+class BboxSensorDescription(SensorEntityDescription):
+    """Describes a sensor."""
+
+    get_value: Callable[..., Any] | None = None
+    value_fn: Callable[..., StateType] | None = None
 
-_LOGGER = logging.getLogger(__name__)
 
 SENSOR_TYPES: tuple[BboxSensorDescription, ...] = (
     BboxSensorDescription(

custom_components/bbox/switch.py

@@ -1,11 +1,12 @@
 """Button for Bbox router."""
 
 import asyncio
-import logging
 from dataclasses import dataclass
+import logging
 from typing import Any, Final
 
 from bboxpy.exceptions import BboxException
+
 from homeassistant.components.switch import SwitchEntity, SwitchEntityDescription
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers.entity_platform import AddEntitiesCallback
@@ -14,8 +15,6 @@
 from .entity import BboxDeviceEntity, BboxEntity
 from .helpers import finditem
 
-_LOGGER = logging.getLogger(__name__)
-
 
 @dataclass(frozen=True)
 class BboxSwitchEntityDescription(SwitchEntityDescription):
@@ -87,6 +86,8 @@ class BboxSwitchEntityDescription(SwitchEntityDescription):
     turn_off="async_set_device_parental_control_state",
 )
 
+_LOGGER = logging.getLogger(__name__)
+
 
 async def async_setup_entry(
     hass: HomeAssistant, entry: BBoxConfigEntry, async_add_entities: AddEntitiesCallback
@@ -157,7 +158,7 @@ class DeviceParentalControlSwitch(BboxDeviceEntity, BboxSwitch):
     def __init__(
         self,
         coordinator: BboxDataUpdateCoordinator,
-        description: SwitchEntityDescription,
+        description: BboxSwitchEntityDescription,
         device: dict[str, Any],
     ) -> None:
         """Initialize."""