Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our first end-to-end tests #423

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Our first end-to-end tests #423

merged 10 commits into from
Jan 18, 2024

Conversation

gsaslis
Copy link
Collaborator

@gsaslis gsaslis commented Nov 27, 2023

No description provided.

Copy link

github-actions bot commented Nov 27, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@gsaslis gsaslis mentioned this pull request Nov 27, 2023
@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch from a873bff to 4d13e9a Compare December 15, 2023 16:18
Copy link

github-actions bot commented Dec 15, 2023

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Commented out code ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch from 4d13e9a to fb4e708 Compare December 19, 2023 16:39
@gsaslis gsaslis marked this pull request as draft December 20, 2023 08:26
@gsaslis gsaslis changed the title e2e tests setup [WIP] e2e tests setup Dec 20, 2023
@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch 6 times, most recently from e9e8f70 to 5deb39e Compare December 21, 2023 12:12
Copy link

github-actions bot commented Jan 12, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch from f32df12 to a7be6b0 Compare January 12, 2024 13:48
Yorgos Saslis and others added 3 commits January 15, 2024 13:53
…aults

Rather than *requiring* users to go to the Settings screen for every new project they open and click 'OK' on the auto-detected values, we now pre-fill these values as defaults. Users still have the option of overriding these values to their own.

Signed-off-by: Yorgos Saslis <[email protected]>
… a project already loaded

Signed-off-by: Yorgos Saslis <[email protected]>
@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch 8 times, most recently from 68cb15e to 462e148 Compare January 17, 2024 14:51
gsaslis and others added 4 commits January 18, 2024 08:55
…issue

- switches to unencrypted radicle key and correct env var to open project
- also correctly registers `uiTest` and `endToEndTests` as junit tasks
- separates "ui" from "e2e" tests
- delegates opening the project to the tests, instead of firing up IntelliJ with this target project
- ensures repo is writable
- switches to matrix job
- increased waiting time for IDEA to start
- video-recorder improvements / fixes

from https://github.com/JetBrains/intellij-ui-test-robot/tree/master/ui-test-example#video-recording

Signed-off-by: Yorgos Saslis <[email protected]>
Signed-off-by: Stelios Mavrommatakis <[email protected]>
Co-authored-by: Yorgos Saslis <[email protected]>
avoid delays in project import
- by retrying to open settings
- by waiting for git menu to show
- uses correct annotation for video recording
- ensures project has been fully loaded
- removes unnecessary screenshots, now that we have video recording working again
- only set values if they haven't already been set / auto-detected, to save some compute/time
- settings title takes macOS into account
- improves how we wait for project to load
- ensures path is correct on windows

Signed-off-by: Yorgos Saslis <[email protected]>
@gsaslis gsaslis force-pushed the feat/e2e_tests_setup branch from 1ca8f36 to 492c903 Compare January 18, 2024 07:03
@gsaslis gsaslis changed the title [WIP] e2e tests setup e2e tests setup Jan 18, 2024
@gsaslis gsaslis changed the title e2e tests setup Our first end-to-end tests Jan 18, 2024
@gsaslis gsaslis requested review from JChrist and Stelios123 and removed request for JChrist January 18, 2024 07:04
@gsaslis gsaslis marked this pull request as ready for review January 18, 2024 07:04
@JChrist JChrist merged commit 492c903 into main Jan 18, 2024
10 checks passed
@JChrist JChrist deleted the feat/e2e_tests_setup branch January 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants