Skip to content

Commit

Permalink
Modify the comment filed length limit to 1024.
Browse files Browse the repository at this point in the history
  • Loading branch information
czd890 committed May 10, 2021
1 parent 95a13ea commit bf2cc7c
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 6 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ target
# Idea
.idea
*.iml
.vs

# git
*.orig
Expand Down
4 changes: 2 additions & 2 deletions apollo-portal/src/main/resources/static/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@
"Valdr.AppNamespace.Comment.Size": "Comment length should not exceed 64 characters",
"Valdr.Item.Key.Size": "Key cannot be longer than 128 characters",
"Valdr.Item.Key.Required": "Key can't be empty",
"Valdr.Item.Comment.Size": "Comment length should not exceed 64 characters",
"Valdr.Item.Comment.Size": "Comment length should not exceed 1024 characters",
"Valdr.Release.ReleaseName.Size": "Release Name cannot be longer than 64 characters",
"Valdr.Release.ReleaseName.Required": "Release Name cannot be empty",
"Valdr.Release.Comment.Size": "Comment length should not exceed 64 characters",
"Valdr.Release.Comment.Size": "Comment length should not exceed 1024 characters",
"ApolloConfirmDialog.DefaultConfirmBtnName": "OK",
"ApolloConfirmDialog.SearchPlaceHolder": "Search items (App Id, App Name)",
"RulesModal.ChooseInstances": "Select from the list of instances",
Expand Down
4 changes: 2 additions & 2 deletions apollo-portal/src/main/resources/static/i18n/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@
"Valdr.AppNamespace.Comment.Size": "备注长度不能多于64个字符",
"Valdr.Item.Key.Size": "Key长度不能多于128个字符",
"Valdr.Item.Key.Required": "Key不能为空",
"Valdr.Item.Comment.Size": "备注长度不能多于64个字符",
"Valdr.Item.Comment.Size": "备注长度不能多于1024个字符",
"Valdr.Release.ReleaseName.Size": "Release Name长度不能多于64个字符",
"Valdr.Release.ReleaseName.Required": "Release Name不能为空",
"Valdr.Release.Comment.Size": "备注长度不能多于64个字符",
"Valdr.Release.Comment.Size": "备注长度不能多于1024个字符",
"ApolloConfirmDialog.DefaultConfirmBtnName": "确认",
"ApolloConfirmDialog.SearchPlaceHolder": "搜索项目(AppId、项目名)",
"RulesModal.ChooseInstances": "从实例列表中选择",
Expand Down
4 changes: 2 additions & 2 deletions apollo-portal/src/main/resources/static/scripts/valdr.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ application_module.config(function (valdrProvider) {
},
'comment': {
'size': {
'max': 64,
'max': 1024,
'message': 'Valdr.Item.Comment.Size'
}
}
Expand All @@ -95,7 +95,7 @@ application_module.config(function (valdrProvider) {
},
'comment': {
'size': {
'max': 64,
'max': 1024,
'message': 'Valdr.Release.Comment.Size'
}
}
Expand Down
29 changes: 29 additions & 0 deletions scripts/sql/delta/xignite/upgrade.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
Use ApolloConfigDB;

ALTER TABLE `AppNamespace`
MODIFY COLUMN `Name` VARCHAR(128) NOT NULL DEFAULT 'default';

ALTER TABLE `GrayReleaseRule`
MODIFY COLUMN `NamespaceName` VARCHAR(128) NOT NULL DEFAULT 'default';

ALTER TABLE `AppNamespace`
MODIFY COLUMN `Name` VARCHAR(128) NOT NULL DEFAULT 'default';

ALTER TABLE `Audit`
MODIFY COLUMN `Comment` VARCHAR(1024) DEFAULT 'default';

ALTER TABLE `Commit`
MODIFY COLUMN `Comment` VARCHAR(1024) DEFAULT 'default';

ALTER TABLE `Release`
MODIFY COLUMN `Comment` VARCHAR(1024) DEFAULT 'default';






Use ApolloPortalDB;

ALTER TABLE `AppNamespace`
MODIFY COLUMN `Name` VARCHAR(128) NOT NULL DEFAULT 'default';

0 comments on commit bf2cc7c

Please sign in to comment.