domaci ukol #3
domaci ukol #3
Conversation
There was a problem hiding this comment.
Okomenotvala jsem ti tenhle PR, ale ve vysledku ho zamitnu, jelikoz je to merge do forkleho repa, nikoliv do tveho repa. Pri vytvareni PR musis zmenit ten czechitas na svuj LDLenka, aby to smerovalo do tveho repa.
Co se tyce ukolu, tak za me hezke. Jenom jsem dala v podstate komentare k organizaci testu a nejaka doporuceni.
src/tests/homework.spec.js
Outdated
| }); | ||
| }); | ||
|
|
||
| function getUniqueEmail() { |
There was a problem hiding this comment.
funkce je schovana mezi testy. lepsi by bylo ji dat na zacatek radek 3 cca, nebo do jineho souboru uplne.
| await expect(page.getByLabel('Kontrola hesla')).toBeVisible() | ||
| }); | ||
|
|
||
| await test.step('kontrola zobrazeni oproti screenshotu', async () => { |
There was a problem hiding this comment.
v tomhle kroku k zadne kontrole screenshotu nedocazi, pouze se screenshot vytvari.
lepsi pouzit await expect(page).toHaveScreenshot();
https://playwright.dev/docs/test-snapshots
src/tests/homework.spec.js
Outdated
| const fullname = 'Lenka Nová'; | ||
| const password = 'Lenka123'; | ||
|
|
||
| console.log(email); |
There was a problem hiding this comment.
console.logy do testu uplne nepatri to je spis pro vlastni debugging ✂️
src/tests/homework.spec.js
Outdated
| test.beforeEach(async ({ page }) => { | ||
| await page.goto('/registrace'); | ||
| const fullname = 'Lenka Nová' | ||
| console.log(fullname); |
src/tests/homework.spec.js
Outdated
|
|
||
| const email = `[email protected]`; | ||
| const password = 'LenkaNova123' | ||
| console.log(email); |
src/tests/homework.spec.js
Outdated
| const email = getUniqueEmail(); | ||
| const password = '1234567890123'; | ||
|
|
||
| console.log(email); |
src/tests/homework.spec.js
Outdated
|
|
||
| test('3 registrace uzivatele s existujicim mailem', async ({ page }) => { | ||
|
|
||
| const email = `[email protected]`; |
There was a problem hiding this comment.
je dobre primo pojmenovat konstantu existingEmail, at je to specificke a nikdo jiny se nemusi ptat: co je to za email?
| import { test, expect } from '@playwright/test'; | ||
| const { v4: uuidv4 } = require('uuid'); | ||
|
|
||
|
|
There was a problem hiding this comment.
tohle jenom organizacni doporuceni. Scenare mohly byt rozdeleny do dvou describe bloku, nebo vsechny v jednom. Tady to zacina be describe bloku a pozdeji mas definovay describe blok, tak mi to prijde mene prehledne.
tady je link na spravny PR - https://github.com/LDLenka/test-automation-playwright-js/pull/2/files |
No description provided.