Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Retries #61

Merged
merged 6 commits into from
Oct 26, 2020
Merged

Support Retries #61

merged 6 commits into from
Oct 26, 2020

Conversation

EJH2
Copy link
Collaborator

@EJH2 EJH2 commented Oct 24, 2020

This PR adds support for retries as noted in #54.

  • Retries will now fill the bar with red with a notice for how long until the next retry, and then the bar will start over with next progress update
  • Created custom retry handling method in JS to allow users to extend current behavior

@EJH2 EJH2 requested a review from OmarWKH October 25, 2020 04:15
@EJH2
Copy link
Collaborator Author

EJH2 commented Oct 25, 2020

Once this gets reviewed I'll see about how to implement the other two states, as well as taking a crack at some other long-standing issues. Just need to get this into the working tree so I can start.

@EJH2 EJH2 requested a review from czue October 25, 2020 04:16
OmarWKH
OmarWKH approved these changes Oct 25, 2020
View reviewed changes
Copy link
Collaborator

@OmarWKH OmarWKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

In addition to my comment above, we could do the following later:

  • Use data.state more often.
  • Stop polling until the retry starts.

@EJH2
Copy link
Collaborator Author

EJH2 commented Oct 25, 2020

If there are no other objections, I'll go ahead merge this in

@EJH2 EJH2 merged commit 2774777 into master Oct 26, 2020
@EJH2 EJH2 deleted the feat-support-retries branch October 26, 2020 02:59
@EJH2 EJH2 mentioned this pull request Oct 26, 2020
Closed
@czue
Copy link
Owner

czue commented Oct 26, 2020

Sorry I was slow but this looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarWKH OmarWKH OmarWKH approved these changes

@czue czue Awaiting requested review from czue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EJH2 @czue @OmarWKH