Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the start of AHBWRAM to be immediately after the VECTORS #827

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Move the start of AHBWRAM to be immediately after the VECTORS #827

merged 1 commit into from
Aug 23, 2023

Conversation

Wolfvak
Copy link
Collaborator

@Wolfvak Wolfvak commented Aug 20, 2023

Fixes #826

@Wolfvak Wolfvak requested review from d0k3 and aspargas2 August 20, 2023 15:50
@Wolfvak Wolfvak changed the title Reduce the size of AHBWRAM section to 488K Move the start of AHBWRAM to be immediately after the VECTORS Aug 20, 2023
d0k3
d0k3 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Owner

@d0k3 d0k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you know much better than me anyways :).

@Wolfvak Wolfvak merged commit 14b390a into d0k3:master Aug 23, 2023
1 check passed
MisterSheeple pushed a commit to MisterSheeple/DumpATron3D that referenced this pull request Apr 19, 2024
@Wolfvak @MisterSheeple
Move the start of AHBWRAM to be immediately after the VECTORS (d0k3#827)
c7e5a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0k3 d0k3 d0k3 approved these changes

@aspargas2 aspargas2 Awaiting requested review from aspargas2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] AHBWRAM section can overflow into hardcoded BootROM copy space
2 participants
@Wolfvak @d0k3