Fix multi RedNAND setup in SD format menu #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me and can be merged. But, why does the automatic check fail? It's not about the changes in this pr. |
|
I updated the workflow so it succeeds now. Test build can be downloaded here. |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SD format menu allows the setup of 2x, 3x, or 4x multi RedNANDs.
Using the 3x and 4x options works properly, but using the 2x option, the SysNAND is only copied to the space reserved for the first RedNAND, leaving the other one without proper setup.
This results in the inability to access this EmuNAND space even when attempting to use the
Switch EmuNANDoption in themore...menu.I have provided a fix which should allow for proper intialization of multi RedNAND setups, while keeping support for single Gateway type EmuNANDs.