Analyzer: Speed up scans #1179
Merged
Analyzer: Speed up scans #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
enhancement
Defer scanning apps in details until the user actually needs it. During the first pass of all apps, we only do a "shallow" scan, and then only if the enters the app details, then we do a deep scan.
Introduce new gateway method to just look op sizes like `du`. More efficient than doing complete lookups that are then summed.
d4rken
force-pushed
the
analyzer-delayed-app-loading
branch
from
e4e5704 to
ded21c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer scanning apps in details until the user actually needs it. During the first pass of all apps, we only do a "shallow" scan, and then only if the enters the app details, then we do a deep scan.
The "shallow" scan uses the systems app storage stats as base information, actually scanning the files of each then only happens on demand.
This is a little less accurate, but a lot faster, and worth the trade off imho.