Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Proposal #3

wants to merge 6 commits into from

Conversation

cupcakearmy
Copy link

@cupcakearmy cupcakearmy commented Aug 26, 2023

  • Works with relative links
  • Reduces further the size of bundle, by using brotli compression
  • clean up code a bit
  • no service worker was implemented here

Demo blaze.nicco.io

Kapture.2023-08-26.at.02.31.21.mp4

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for lively-starburst-8afb8a ready!

Name Link
🔨 Latest commit 277ea25
🔍 Latest deploy log https://app.netlify.com/sites/lively-starburst-8afb8a/deploys/64f86d92cc9c340008f090fc
😎 Deploy Preview https://deploy-preview-3--lively-starburst-8afb8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daaanny90
Copy link
Owner

@cupcakearmy amazing PR, thank you very much, I really appreciate the time and effort you put into this. The performance are also incredible.

Just two points:

  • In this proposal there is no more service worker, this means that the offline use of Blaze will be no more possible. I could live also with this decision, but the vision was to let people use Blaze also in "emergency" situations, also without a connection. Probably is extremely rare that somebody would search again the same thing without connection, therefore the idea was to implement a kind of list of most searched terms or a list of most useful searches in case of emergency and give those offline pages out of the box to the users. Again, I could live also without this feature and I am also not 100% sure if this feature worth the effort, but this is a good chance to hear also your point of view on that.
  • One more important feature that is removed in your proposal is the read mode parsing. The package @mozilla/readability was there to parse the page and to give back the page in "read mode", to improve readability and to serve a lighter page. To better understand what I mean, you can navigate with your proposal on a Wikipedia page and then try with the current Blaze version. You will see that the current Blaze will give you a clean and readable page. Not all pages can be parsed and served in read mode (think about Reddit for example), in this case a note was showed at the very top of the page, saying that the page was impossible to parse and serve in a clean a readable mode, but that Blaze serve anyway a very light version of the page, but that maybe the page could be hard to read and understand. This is a nice feature, I think we can talk a bit on how to implement that. Maybe could be opt-out? e.g. If a user want to see the complete page, can disable the parsing in read mode. Just an Idea.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants