FIX: slow read_off method
#353
Conversation
ADDED comment parameter to skip comment rows and end of line comments CHANGED to c engine to increase drastically the performance ADDED n_rows and REMOVED skipfooter to use c engine ADDED dtype parameter to directly cast the element types SET points read_csv to off buffer: no skip of first lines needed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fixed typo in parameters name Added n_points and n_faces default as 0
|
Not sure how to act if a file exists and respects the standard but has no points and no shapes. |
I think it is ok (and would prefer it) to raise an exception. People could handle exceptions in their loop |
|
@daavoo done 🦤 |
|
Kindly pinging to remind someone about this <3 |
|
Just on the commit f9bbff7, this works for me 👍 |
Had to use this method for a project and it was incredibly slow.
Fixed changing the engine and tweaking the parameters so that no new import is required.
Also fixes:
DataFrameI tried to modify the least I could.
Problems not solved: