Use renderSuggestions as React component rather than calling directly #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #44, this patch slightly changes the return type of
renderSuggestions
and renders it as a React element rather than populating a fragment with its output. This is a subtle distinction but allows the function component passed asrenderSuggestions
to be hooks-based without having to wrap it in a(props) => ( <MentionSuggestions {...props} /> )
anonymous function.I will understand if you do not want to incorporate this, as it is potentially a breaking change for people who are returning less typical ReactNode values from their
renderSuggestions
functions.