Upgrade to use redis v4 #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to redis v4 (and types) * Bump node to >=14, required for redis * Bump jest version to fix queueMicrotask missing jestjs/jest#9139
* Export url generation function that can take existing cache options to create a valid connection url for redis v4 * Wrap all cache functions in a connect promise since v4 does not auto connect https://github.com/redis/node-redis/blob/master/docs/v3-to-v4.md * Include 'legacyMode' option in redis client creation so most of existing code can be used in place * Fix isCacheableValue usage * Use v4 client for disconnect in tests
|
For the second failing test -- defaults are set in |
|
+1 |
|
@MatthiasKunnen I'd prefer if you addressed the failing tests. The url is generated correctly regardless, at this point. |
|
First of all, thank you for your support and your pull request. It is much appreciated. I am happy to inform you that I have just released v3.0.0 of this package on npm which upgrades the redis dependency to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package to work with redis v4 #40
While the package doesn't change functionally the dependencies have major changes (minimum node 14 for example) so would be better off bumping node-cache-manager-redis-store to v3.0.0
TODO
mset.should return an error if there is an error acquiring a connectionis failingmultiobject is a new instance and not yet connected?defaults are set by redis itselfis failing