Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap raw types into a StageSchema class #7

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
176270b
wip
dagardner-nv Sep 29, 2023
3593eb9
wip
dagardner-nv Sep 29, 2023
e788c81
First pass at PortSchema and StageSchema classes
dagardner-nv Sep 29, 2023
b7d1848
Single port helpers
dagardner-nv Sep 29, 2023
de86b9c
wip
dagardner-nv Sep 29, 2023
e5a1002
WIP
dagardner-nv Sep 29, 2023
2978f1f
docstrings
dagardner-nv Oct 2, 2023
16d3f92
WIP
dagardner-nv Oct 2, 2023
679e534
consolidate input schema logic
dagardner-nv Oct 2, 2023
0cdb077
WIP
dagardner-nv Oct 2, 2023
3c56a81
WIP
dagardner-nv Oct 2, 2023
aaa8187
Update the pass-thru-mixin
dagardner-nv Oct 2, 2023
c490ab9
Replace output_type with compute_schema
dagardner-nv Oct 2, 2023
e455b96
Fixing type-os
dagardner-nv Oct 2, 2023
120636b
Fix type-os for viz
dagardner-nv Oct 2, 2023
3ff29d3
Temporarily skip failing test DO NOT MERGE
dagardner-nv Oct 2, 2023
8ae4167
Revert "Temporarily skip failing test DO NOT MERGE"
dagardner-nv Oct 2, 2023
6546644
Complete port schemas produced on the fly by the receiver
dagardner-nv Oct 2, 2023
ff48df3
Lint fixes [no ci]
dagardner-nv Oct 2, 2023
61b3cb1
Add pinned libwebp to resolve CVE (#1236)
drobison00 Oct 4, 2023
7aaec71
Add libwebp to meta.yaml for CVE 2307 (#1242)
drobison00 Oct 5, 2023
36ccb8e
Adds support to read and write to Databricks delta tables (#630)
pthalasta Oct 5, 2023
1b6e9f2
[BUG] Fix Control Message Utils & SQL Max Connections Exhaust (#1243)
bsuryadevara Oct 5, 2023
d39a17f
Merge branch-23.07 into branch-23.11
dagardner-nv Oct 5, 2023
865b0e3
Remove conflicting condarc file from base image
dagardner-nv Oct 5, 2023
7682ae4
Fix linting errors
dagardner-nv Oct 5, 2023
6fb88d1
Fix mlflow version constraint to match that of 23.11
dagardner-nv Oct 5, 2023
f783abd
Fix mlflow version
dagardner-nv Oct 5, 2023
f1bb834
Merge pull request #1246 from dagardner-nv/branch-23.11-merge-23.07
dagardner-nv Oct 5, 2023
d5a55ac
Rename StreamWrapper to BaseStage to reflect that we are no longer us…
dagardner-nv Oct 5, 2023
5d06a45
WIP: [no ci]
dagardner-nv Oct 5, 2023
64cd7f8
WIP: [no ci]
dagardner-nv Oct 5, 2023
98b1140
Indicate that the as_shared_pointer parameter is unused [no ci]
dagardner-nv Oct 5, 2023
94fb3a7
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Oct 5, 2023
763b88e
Update deltalake stages to support stage schemas [no ci]
dagardner-nv Oct 5, 2023
d57ec20
Remove unused import [no ci]
dagardner-nv Oct 5, 2023
3c0863f
Allow test to run in both Python & C++ mode [no ci]
dagardner-nv Oct 5, 2023
f2803db
Mark the complete method as private [no ci]
dagardner-nv Oct 5, 2023
c521cd4
[DRAFT] Add model and experiment template 'click' options to dfp exam…
drobison00 Oct 5, 2023
7cf3c47
Tests for PortSchema [no ci]
dagardner-nv Oct 5, 2023
f0bb070
WIP tests: [no ci]
dagardner-nv Oct 6, 2023
ca72c43
WIP [no ci]
dagardner-nv Oct 6, 2023
bae6e4e
First pass at some mult-port stages for testing [no ci]
dagardner-nv Oct 6, 2023
a7627d1
WIP [no ci]
dagardner-nv Oct 6, 2023
17b7941
WIP tests [no ci]
dagardner-nv Oct 6, 2023
4dcaad3
Move pipeline tests into tests/pipeline
dagardner-nv Oct 6, 2023
9ee5601
Assert that when stages are passed into the add_edge method they only…
dagardner-nv Oct 6, 2023
0aa0f9b
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Oct 6, 2023
65ff2c5
Remove unused imports [no ci]
dagardner-nv Oct 6, 2023
f3a7fa1
Remove TODO comment, will resolve docs in separate PR
dagardner-nv Oct 9, 2023
18438cd
Ignore pylint warning
dagardner-nv Oct 9, 2023
e0a0ea2
Fix import sorting
dagardner-nv Oct 9, 2023
0772f87
Update to clang-16 & boost-1.82 (#1186)
dagardner-nv Oct 11, 2023
a32ac8f
Merge branch 'branch-23.11' into david-pipe-build-refactor-stage-schema
dagardner-nv Oct 11, 2023
20afe30
Revert unintentional change
dagardner-nv Oct 11, 2023
6ad39c8
Updating versions for v23.07.03
mdemoret-nv Oct 11, 2023
82b291a
Updating CHANGELOG
mdemoret-nv Oct 11, 2023
5443da9
Fixing an issue with the incorrect version being used to register a m…
mdemoret-nv Oct 11, 2023
06bda2d
IWYU fixes
mdemoret-nv Oct 11, 2023
e92e698
Loosen nodejs version restriction (#1262)
dagardner-nv Oct 13, 2023
8ac2703
Merge branch 'branch-23.07' into branch-23.11-merge-23.07
mdemoret-nv Oct 13, 2023
502d923
Updating out of date version
mdemoret-nv Oct 13, 2023
61d9c8c
Merge pull request #1263 from mdemoret-nv/branch-23.11-merge-23.07
mdemoret-nv Oct 13, 2023
9348842
Fix documentation for morpheus.loaders.sql_loader (#1264)
dagardner-nv Oct 13, 2023
c320903
Add a Vector Database Service to allow stages to read and write to VD…
bsuryadevara Oct 13, 2023
78c6e3a
Use conda environment yaml's for training-tuning-scripts (#1256)
efajardo-nv Oct 13, 2023
ea8579a
WIP: Rename BaseStage to StageBase
dagardner-nv Oct 19, 2023
27d9ca5
WIP: Rename BaseStage to StageBase
dagardner-nv Oct 19, 2023
7a57b82
WIP: Rename BaseStage to StageBase
dagardner-nv Oct 19, 2023
dce7991
Merge branch 'branch-23.11' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Oct 19, 2023
55052e7
Update WriteToVectorDBStage
dagardner-nv Oct 19, 2023
b43f3c7
Fix import order
dagardner-nv Oct 19, 2023
14ce114
Fix import order
dagardner-nv Oct 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@ See the License for the specific language governing permissions and
limitations under the License.
-->

# Morpheus 23.07.03 (11 Oct 2023)

## 🐛 Bug Fixes
- Add pinned libwebp to resolve CVE ([#1236](https://github.com/nv-morpheus/Morpheus/pull/1236)) [@drobison00](https://github.com/drobison00)
- Add libwebp to meta.yaml for CVE 2307 ([#1242](https://github.com/nv-morpheus/Morpheus/pull/1242)) [@drobison00](https://github.com/drobison00)
- [BUG] Fix Control Message Utils & SQL Max Connections Exhaust ([#1243](https://github.com/nv-morpheus/Morpheus/pull/1243)) [@bsuryadevara](https://github.com/bsuryadevara)

# Morpheus 23.07.02 (25 Jul 2023)

## 🐛 Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion ci/conda/recipes/morpheus/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ python:
- 3.10

boost:
- 1.74
- 1.82

rapids_version:
- 23.06
3 changes: 2 additions & 1 deletion ci/conda/recipes/morpheus/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ outputs:
- docker-py 5.0.*
- grpcio # Version determined from cudf
- libmrc
- mlflow >=2.2.1,<3
- libwebp>=1.3.2 # Required for CVE mitigation: https://nvd.nist.gov/vuln/detail/CVE-2023-4863
- mlflow>=2.2.1,<3
- mrc
- networkx 3.1.*
- numpydoc 1.4.*
Expand Down
4 changes: 2 additions & 2 deletions ci/scripts/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ export SKIP_YAPF=${SKIP_YAPF:-""}
# Set BUILD_DIR to use a different build folder
export BUILD_DIR=${BUILD_DIR:-"${MORPHEUS_ROOT}/build"}

# Speficy the clang-tools version to use. Default 14
export CLANG_TOOLS_VERSION=${CLANG_TOOLS_VERSION:-14}
# Speficy the clang-tools version to use. Default 16
export CLANG_TOOLS_VERSION=${CLANG_TOOLS_VERSION:-16}

# Returns the `branch-YY.MM` that is used as the base for merging
function get_base_branch() {
Expand Down
4 changes: 4 additions & 0 deletions ci/scripts/github/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ function update_conda_env() {

if [[ "${SKIP_CONDA_ENV_UPDATE}" == "" ]]; then
rapids-logger "Checking for updates to conda env"

# Remove default/conflicting channels from base image
rm /opt/conda/.condarc

# Update the packages
rapids-mamba-retry env update -n morpheus --prune -q --file ${ENV_YAML}
fi
Expand Down
1 change: 1 addition & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ RUN --mount=type=cache,id=apt,target=/var/cache/apt \
libcurand-${CUDA_MAJOR_VER}-${CUDA_MINOR_VER} \
libcusolver-${CUDA_MAJOR_VER}-${CUDA_MINOR_VER} \
libnuma1 \
openjdk-11-jre-headless \
openssh-client \
pkg-config \
tar \
Expand Down
12 changes: 8 additions & 4 deletions docker/conda/environments/cuda11.8_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ dependencies:
####### Morpheus Dependencies (keep sorted!) #######
- automake=1.16.5
- benchmark=1.6.1
- boost-cpp=1.74
- boost-cpp=1.82
- cachetools=5.0.0
- ccache>=3.7
- clangdev=14
- clangdev=16
- click >=8
- cmake=3.24
- configargparse=1.5
Expand Down Expand Up @@ -58,18 +58,19 @@ dependencies:
- grpcio
- gtest>=1.13.0
- gxx_linux-64=11.2
- include-what-you-use=0.18
- include-what-you-use=0.20
- ipywidgets
- isort
- jupyter_core>=4.11.2,<5.0
- jupyterlab
- libgrpc>=1.49
- librdkafka=1.9.2
- libwebp>=1.3.2 # Required for CVE mitigation: https://nvd.nist.gov/vuln/detail/CVE-2023-4863
- mlflow>=2.2.1,<3
- mrc=23.11
- networkx=3.1
- ninja=1.10
- nodejs=18.15.0
- nodejs=18.*
- numba>=0.56.2
- numpydoc=1.4
- nvtabular=23.06
Expand Down Expand Up @@ -107,4 +108,7 @@ dependencies:
####### Morpheus Pip Dependencies (keep sorted!) #######
- pip:
# Add additional dev dependencies here
- databricks-connect
- pytest-kafka==0.6.0
- pymilvus==2.3.1
- milvus
1 change: 1 addition & 0 deletions docker/conda/environments/cuda11.8_examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ dependencies:
- dgl=1.0.2
- dill=0.3.6
- distributed>=2023.1.1
- libwebp>=1.3.2 # Required for CVE mitigation: https://nvd.nist.gov/vuln/detail/CVE-2023-4863
- mlflow>=2.2.1,<3
- papermill=2.3.4
- s3fs>=2023.6
2 changes: 2 additions & 0 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,12 @@
autodoc_mock_imports = [
"cudf", # Avoid loading GPU libraries during the documentation build
"cupy", # Avoid loading GPU libraries during the documentation build
"databricks.connect",
"merlin",
"morpheus.cli.commands", # Dont document the CLI in Sphinx
"nvtabular",
"pandas",
"pymilvus",
"tensorrt",
"torch",
"tqdm",
Expand Down
9 changes: 5 additions & 4 deletions docs/source/developer_guide/guides/3_simple_cpp_stage.md
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,13 @@ PYBIND11_MODULE(morpheus_example, m)

### Python Changes

We need to make a few minor adjustments to our Python implementation of the `PassThruStage`.
We need to make a few minor adjustments to our Python implementation of the `PassThruStage`. First, we import the new `morpheus_example` Python module we created in the previous section.

As mentioned in the previous section, we will need to change the return value of the `supports_cpp_node` method to indicate that our stage now supports a C++ implementation. Our `_build_single` method needs to be updated to build a C++ node when `morpheus.config.CppConfig.get_should_use_cpp()` is `True` using the `self._build_cpp_node()` method. The `_build_cpp_node()` method compares both `morpheus.config.CppConfig.get_should_use_cpp()` and `supports_cpp_node()` and returns `True` only when both methods return `True`.
```python
from _lib import morpheus_example as morpheus_example_cpp
```

We lazily import the new `morpheus_example` Python module we created in the previous section only when we need to build a C++ node since importing a compiled extension module comes at a performance cost.
As mentioned in the previous section, we will need to change the return value of the `supports_cpp_node` method to indicate that our stage now supports a C++ implementation. Our `_build_single` method needs to be updated to build a C++ node when `morpheus.config.CppConfig.get_should_use_cpp()` is `True` using the `self._build_cpp_node()` method. The `_build_cpp_node()` method compares both `morpheus.config.CppConfig.get_should_use_cpp()` and `supports_cpp_node()` and returns `True` only when both methods return `True`.

```python
def supports_cpp_node(self):
Expand All @@ -349,7 +351,6 @@ def supports_cpp_node(self):
```python
def _build_single(self, builder: mrc.Builder, input_stream: StreamPair) -> StreamPair:
if self._build_cpp_node():
from _lib import morpheus_example as morpheus_example_cpp
node = morpheus_example_cpp.PassThruStage(builder, self.unique_name)
else:
node = builder.make_node(self.unique_name, ops.map(self.on_data))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from morpheus.pipeline.single_port_stage import SinglePortStage


# TODO: Document the PassThruTypeMixin
@register_stage("pass-thru")
class PassThruStage(PassThruTypeMixin, SinglePortStage):
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from morpheus.messages.message_meta import MessageMeta
from morpheus.pipeline.preallocator_mixin import PreallocatorMixin
from morpheus.pipeline.single_output_source import SingleOutputSource
from morpheus.pipeline.stage_schema import StageSchema

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -85,8 +86,8 @@ def name(self) -> str:
def supports_cpp_node(self) -> bool:
return False

def output_type(self) -> type:
return MessageMeta
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(MessageMeta)

def stop(self):
# Indicate we need to stop
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ function(find_and_configure_SimpleAmqpClient version)
# Needed to pick up the generated export.h
target_include_directories(SimpleAmqpClient PUBLIC "${rabbitmq_BINARY_DIR}/include")

# Suppress #warning deprecation messages from rabbitmq
target_compile_options(SimpleAmqpClient PRIVATE -Wno-cpp)
# Suppress #warning deprecation messages from rabbitmq and SimpleAmqpClient
# https://github.com/nv-morpheus/Morpheus/issues/1255
target_compile_options(SimpleAmqpClient PRIVATE -Wno-cpp -DBOOST_DISABLE_PRAGMA_MESSAGE)

endfunction()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from morpheus.messages.message_meta import MessageMeta
from morpheus.pipeline.preallocator_mixin import PreallocatorMixin
from morpheus.pipeline.single_output_source import SingleOutputSource
from morpheus.pipeline.stage_schema import StageSchema

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -81,8 +82,8 @@ def name(self) -> str:
def supports_cpp_node(self) -> bool:
return True

def output_type(self) -> type:
return MessageMeta
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(MessageMeta)

def _build_source(self, builder: mrc.Builder) -> mrc.SegmentObject:
if self._build_cpp_node():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

from morpheus.config import Config
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema

logger = logging.getLogger(f"morpheus.{__name__}")

Expand Down Expand Up @@ -107,8 +108,8 @@ def accepted_types(self) -> typing.Tuple:
"""Accepted incoming types for this stage"""
return (fsspec.core.OpenFiles, )

def output_type(self, parent_output_type: type) -> type:
return typing.Tuple[fsspec.core.OpenFiles, int]
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(typing.Tuple[fsspec.core.OpenFiles, int])

def on_data(self, file_objects: fsspec.core.OpenFiles) -> typing.List[typing.Tuple[fsspec.core.OpenFiles, int]]:
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from morpheus.controllers.file_to_df_controller import FileToDFController
from morpheus.pipeline.preallocator_mixin import PreallocatorMixin
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema
from morpheus.utils.column_info import DataFrameInputSchema

logger = logging.getLogger(f"morpheus.{__name__}")
Expand Down Expand Up @@ -83,8 +84,8 @@ def accepted_types(self) -> typing.Tuple:
"""Accepted input types."""
return (typing.Any, )

def output_type(self, parent_output_type: type) -> type:
return pd.DataFrame
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(pd.DataFrame)

def _build_single(self, builder: mrc.Builder, input_node: mrc.SegmentObject) -> mrc.SegmentObject:
node = builder.make_node(self.unique_name,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from morpheus.config import Config
from morpheus.messages.multi_ae_message import MultiAEMessage
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema

from ..messages.multi_dfp_message import MultiDFPMessage
from ..utils.model_cache import ModelCache
Expand Down Expand Up @@ -71,8 +72,8 @@ def accepted_types(self) -> typing.Tuple:
"""Accepted input types."""
return (MultiDFPMessage, )

def output_type(self, parent_output_type: type) -> type:
return MultiAEMessage
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(MultiAEMessage)

def get_model(self, user: str) -> ModelCache:
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

from morpheus.config import Config
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema

from ..messages.multi_dfp_message import DFPMessageMeta
from ..messages.multi_dfp_message import MultiDFPMessage
Expand Down Expand Up @@ -90,8 +91,8 @@ def accepted_types(self) -> typing.Tuple:
"""Input types accepted by this stage."""
return (DFPMessageMeta, )

def output_type(self, parent_output_type: type) -> type:
return MultiDFPMessage
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(MultiDFPMessage)

@contextmanager
def _get_user_cache(self, user_id: str) -> typing.Generator[CachedUserWindow, None, None]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

from morpheus.config import Config
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema
from morpheus.utils.type_aliases import DataFrameType

from ..messages.multi_dfp_message import DFPMessageMeta
Expand Down Expand Up @@ -84,8 +85,8 @@ def accepted_types(self) -> typing.Tuple:
"""Input types accepted by this stage."""
return (cudf.DataFrame, pd.DataFrame)

def output_type(self, parent_output_type: type) -> type:
return DFPMessageMeta
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(DFPMessageMeta)

def extract_users(self, message: DataFrameType) -> typing.List[DFPMessageMeta]:
"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from morpheus.messages.multi_ae_message import MultiAEMessage
from morpheus.models.dfencoder import AutoEncoder
from morpheus.pipeline.single_port_stage import SinglePortStage
from morpheus.pipeline.stage_schema import StageSchema

from ..messages.multi_dfp_message import DFPMessageMeta
from ..messages.multi_dfp_message import MultiDFPMessage
Expand Down Expand Up @@ -94,11 +95,11 @@ def accepted_types(self) -> typing.Tuple:
MultiDFPMessage,
)

def output_type(self, parent_output_type: type) -> type:
return_type = parent_output_type
if (return_type == MultiDFPMessage):
return_type = MultiAEMessage
return return_type
def compute_schema(self, schema: StageSchema):
output_type = schema.input_type
if (output_type == MultiDFPMessage):
output_type = MultiAEMessage
schema.output_schema.set_type(output_type)

def _dfp_multimessage_from_control_message(self,
control_message: ControlMessage) -> typing.Union[MultiDFPMessage, None]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

from morpheus.config import Config
from morpheus.pipeline.single_output_source import SingleOutputSource
from morpheus.pipeline.stage_schema import StageSchema

logger = logging.getLogger(f"morpheus.{__name__}")

Expand Down Expand Up @@ -76,8 +77,8 @@ def input_count(self) -> int:
"""Return None for no max intput count"""
return self._input_count

def output_type(self) -> type:
return fsspec.core.OpenFiles
def compute_schema(self, schema: StageSchema):
schema.output_schema.set_type(fsspec.core.OpenFiles)

def supports_cpp_node(self):
"""Indicates whether this stage supports C++ nodes."""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def __init__(self,
source: str,
tracking_uri: str,
silence_monitors: bool,
mlflow_experiment_name_formatter: str,
mlflow_model_name_formatter: str,
train_users: str = None):

self._skip_users = list(skip_user)
Expand All @@ -65,8 +67,8 @@ def __init__(self,
self._time_fields: TimeFields = None
self._silence_monitors = silence_monitors

self._model_name_formatter = f"DFP-{source}-" + "{user_id}"
self._experiment_name_formatter = f"dfp/{source}/training/" + "{reg_model_name}"
self._model_name_formatter = mlflow_model_name_formatter
self._experiment_name_formatter = mlflow_experiment_name_formatter

@staticmethod
def verify_init(func):
Expand Down
Loading
Loading