[dagster-hex] update to latest standards #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmpadden
changed the title
cmpadden
requested review from
maximearmstrong,
C00ldudeNoonan and
PedramNavid
|
@maximearmstrong what are your thoughts on removing |
@cmpadden Very much in favor. I think deprecating the resource makes sense, then we can remove it when the breaking version is released. |
maximearmstrong
requested changes
Dec 10, 2024
cmpadden
added a commit
that referenced
this pull request
Dec 12, 2024
Co-authored-by: colton <[email protected]>
maximearmstrong
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving away from using
resourcedecorated functions as resources, and instead favoringConfigurableResource. This pull request "modernizes" the Hex integration to use aConfigurableResource:ConfigurableResourceforHexResourcehex_resourceHexResourcefrom an assetNext steps will be updating the documentation, and flushing out more examples of using the resource.
Presently, I don't believe we need a
hex_project_assetas we don't derive much for the user automatically, but can instead provide thorough examples of using the resource. This may change in the future, if we decide to generate assets for all projects in a workspace.Unfinished tasks: