-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial consolidation of java & rust jsonschemas #56
Conversation
The original Java Pioes repo had an issue regarding this constructor. Overall, I was hoping you could proceed with the schema changes for Rust without touching Java for now. I imagined we would then reconcile Java with these changes once the schemas are stabilized. Unless @GingerYouth wants to step in and do the necessary Java changes as part of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to @GingerYouth and he'll be able to do Java changes next week. So I suggest we make a separate PR for Java.
As for exception class, I planned to switch to generated class, and move extra functionality to a wrapper. For metadata need to think and test. I can deal with these files next week, when I'll have access to my laptop. |
Thanks for the input @danielgafni & @GingerYouth! I reverted most of changes so that this PR only touches the rust side of things |
Dismissing as changes are no longer targeting Java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary & Motivation
Contributes to #44
This performs an initial step in the consolidation of the types generated on the jsonschema definition between the java & rust implementations of pipes. This pulls out the jsonschema definitions defined in the rust implementation onto a higher level, to be used as the source of truth for the generated types in the future
How I Tested These Changes
Changelog
Ensure that an entry has been created in
CHANGELOG.md
outlining additions, deletions, and/or modifications.See: keepachangelog.com