[dagster-pipes-java] add tests in CI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgafni
force-pushed
the
12-25-_dagster-pipes-java_add_tests_in_ci
branch
3 times, most recently
from
1d08578 to
42791c2
Compare
danielgafni
force-pushed
the
12-25-_dagster-pipes-java_add_tests_in_ci
branch
3 times, most recently
from
f0b578a to
accea96
Compare
GingerYouth
approved these changes
Dec 25, 2024
danielgafni
force-pushed
the
12-25-_dagster-pipes-java_add_tests_in_ci
branch
3 times, most recently
from
baeec0f to
6ba08ae
Compare
danielgafni
force-pushed
the
12-25-_dagster-pipes-java_add_tests_in_ci
branch
from
6ba08ae to
4e3de4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adding tests in CI for Java.
@cmpadden I thought experimenting with Nix in CI would be a good idea.
Take a look at the deps installation step - it's just one command to install all the deps (in our case it's
python310,java8anduv).You can run the same
nix developcommand locally to get an exact copy of the CI env. I think it's pretty useful and should help with setup & debugging.I'm especially excited about Nix usage for Pipes implementations because it can unify dependency management for all the languages in the future.
Resolve #52
How I Tested These Changes
Tests should pass in CI