-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Weaviate Resource #87
Open
shimon-cherrypick
wants to merge
5
commits into
dagster-io:main
Choose a base branch
from
shimon-cherrypick:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,916
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpeng817
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach for the overall resource pattern looks good. Some nits, requests for additional tests, and comments around usage patterns.
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate/resource.py
Outdated
Show resolved
Hide resolved
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate_tests/test_resource.py
Outdated
Show resolved
Hide resolved
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate_tests/test_resource.py
Outdated
Show resolved
Hide resolved
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate_tests/test_resource.py
Show resolved
Hide resolved
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate/resource.py
Outdated
Show resolved
Hide resolved
libraries/dagster-contrib-weaviate/dagster_contrib_weaviate/resource.py
Outdated
Show resolved
Hide resolved
shimon-cherrypick
force-pushed
the
main
branch
3 times, most recently
from
January 7, 2025 21:21
e9e1e58
to
ff9dfc8
Compare
## Summary & Motivation - An integration of dagster with [Weaviate](https://weaviate.io/) - supports both locally-hosted and cloud Weaviate databases. - Includes WeaviateCloudResource, and WeaviateLocalResource. ## How I Tested These Changes - Added unit-tests that create a local weaviate instance, and use the WeaviateLocalResource to query it. - Tested connection to weaviate-cloud locally, using a temporary Weaviate project. includes testing authentication with an API_KEY, and adding additional HTTP headers (e.g. API_KEY for Cohere) ## Changelog Ensure that an entry has been created in `CHANGELOG.md` outlining additions, deletions, and/or modifications. See: [keepachangelog.com](https://keepachangelog.com/en/1.0.0/)
shimon-cherrypick
force-pushed
the
main
branch
from
January 7, 2025 21:26
1ac7d67
to
c50b431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Changelog
Ensure that an entry has been created in
CHANGELOG.md
outlining additions, deletions, and/or modifications.See: keepachangelog.com