fix tests

python_modules/libraries/dagster-dg/dagster_dg/cli/check.py

@@ -9,6 +9,7 @@
 from yaml.scanner import ScannerError
 
 from dagster_dg.cli.check_utils import error_dict_to_formatted_error
+from dagster_dg.cli.dev import format_forwarded_option, temp_workspace_file
 from dagster_dg.cli.global_options import dg_global_options
 from dagster_dg.component import RemoteComponentRegistry
 from dagster_dg.component_key import ComponentKey, LocalComponentKey
@@ -23,8 +24,6 @@
     ValueAndSourcePositionTree,
 )
 
-from .dev import _format_forwarded_option, _temp_workspace_file
-
 
 @click.group(name="check", cls=DgClickGroup)
 def check_group():
@@ -208,8 +207,8 @@ def check_definitions_command(
     dg_context = DgContext.for_deployment_or_code_location_environment(Path.cwd(), cli_config)
 
     forward_options = [
-        *_format_forwarded_option("--log-level", log_level),
-        *_format_forwarded_option("--log-format", log_format),
+        *format_forwarded_option("--log-level", log_level),
+        *format_forwarded_option("--log-format", log_format),
     ]
 
     # In a code location context, we can just run `dagster definitions validate` directly, using `dagster` from the
@@ -234,7 +233,7 @@ def check_definitions_command(
             *forward_options,
         ]
         cmd_location = "ephemeral dagster definitions validate"
-        temp_workspace_file_cm = _temp_workspace_file(dg_context)
+        temp_workspace_file_cm = temp_workspace_file(dg_context)
     else:
         exit_with_error("This command must be run inside a code location or deployment directory.")
 

python_modules/libraries/dagster-dg/dagster_dg/cli/dev.py

@@ -91,12 +91,12 @@ def dev_command(
     dg_context = DgContext.for_deployment_or_code_location_environment(Path.cwd(), cli_config)
 
     forward_options = [
-        *_format_forwarded_option("--code-server-log-level", code_server_log_level),
-        *_format_forwarded_option("--log-level", log_level),
-        *_format_forwarded_option("--log-format", log_format),
-        *_format_forwarded_option("--port", port),
-        *_format_forwarded_option("--host", host),
-        *_format_forwarded_option("--live-data-poll-rate", live_data_poll_rate),
+        *format_forwarded_option("--code-server-log-level", code_server_log_level),
+        *format_forwarded_option("--log-level", log_level),
+        *format_forwarded_option("--log-format", log_format),
+        *format_forwarded_option("--port", port),
+        *format_forwarded_option("--host", host),
+        *format_forwarded_option("--live-data-poll-rate", live_data_poll_rate),
     ]
 
     # In a code location context, we can just run `dagster dev` directly, using `dagster` from the
@@ -130,7 +130,7 @@ def dev_command(
             *forward_options,
         ]
         cmd_location = "ephemeral dagster dev"
-        temp_workspace_file_cm = _temp_workspace_file(dg_context)
+        temp_workspace_file_cm = temp_workspace_file(dg_context)
     else:
         exit_with_error("This command must be run inside a code location or deployment directory.")
 
@@ -167,7 +167,7 @@ def dev_command(
 
 
 @contextmanager
-def _temp_workspace_file(dg_context: DgContext) -> Iterator[str]:
+def temp_workspace_file(dg_context: DgContext) -> Iterator[str]:
     with NamedTemporaryFile(mode="w+", delete=True) as temp_workspace_file:
         entries = []
         for location in dg_context.get_code_location_names():
@@ -186,7 +186,7 @@ def _temp_workspace_file(dg_context: DgContext) -> Iterator[str]:
         yield temp_workspace_file.name
 
 
-def _format_forwarded_option(option: str, value: object) -> list[str]:
+def format_forwarded_option(option: str, value: object) -> list[str]:
     return [] if value is None else [option, str(value)]
 
 

python_modules/libraries/dagster-dg/dagster_dg_tests/cli_tests/test_environment_validation.py

@@ -59,6 +59,7 @@ def to_cli_args(self) -> tuple[str, ...]:
 
 DEPLOYMENT_OR_CODE_LOCATION_CONTEXT_COMMANDS = [
     CommandSpec(("dev",)),
+    CommandSpec(("check", "definitions")),
 ]
 
 # ########################