Use StopIteration instead of invariant in schedule iterator #27936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
python_modules/dagster-graphql/dagster_graphql/schema/schedules/schedules.py
Show resolved
Hide resolved
gibsondan
reviewed
Feb 20, 2025
There was a problem hiding this comment.
I think if we made futureTicks a graphene.Field instead of a graphene.NonNull it would do something similar in that an error would just null out that field instead of nuking the whole query? If we did that we might have to adjust the JS callsites to account for the null case (the build would likely fail until we did that)
Comment on lines
+160
to
+161
| # If the schedule is not valid, we will return an empty list | ||
| pass |
There was a problem hiding this comment.
I think we should add a logging.exception call if we do this so we know what the error was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
It's possible for invalid cron schedules to throw an invariant of the iterator, which breaks places that only expected StopIteration. This PR changes the handling of invalid crons from throwing an invariant violation to yielding nothing from the iterator. I updated the calling code as well to handle StopIteration in both branches (there's only one branch now).
How I Tested These Changes
bk